testing/js_embedder_test.h - Issue 2245863002: Push v8::Isolate into CFXJS_Engine class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: testing/js_embedder_test.h

Issue 2245863002: Push v8::Isolate into CFXJS_Engine class (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Null isolate before letting CFXJS_Engine dtor invoked Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: testing/js_embedder_test.h

diff --git a/testing/js_embedder_test.h b/testing/js_embedder_test.h

index b2bd5a87b1a017651b26695afea5030233da45ca..f0beb1eb299fbe801bedf25cbb889a1c10d1434a 100644

--- a/testing/js_embedder_test.h

+++ b/testing/js_embedder_test.h

@@ -21,12 +21,12 @@ class JSEmbedderTest : public EmbedderTest {

v8::Isolate* isolate();

v8::Local<v8::Context> GetV8Context();

+ CFXJS_Engine* engine() { return m_Engine.get(); }

private:

std::unique_ptr<FXJS_ArrayBufferAllocator> m_pArrayBufferAllocator;

v8::Isolate* m_pIsolate;

- v8::Global<v8::Context> m_pPersistentContext;

- std::vector<v8::Global<v8::Object>*> m_StaticObjects;

+ std::unique_ptr<CFXJS_Engine> m_Engine;

};

#endif // TESTING_JS_EMBEDDER_TEST_H_

« no previous file with comments | « fxjs/include/fxjs_v8.h ('k') | testing/js_embedder_test.cpp » ('j') | no next file with comments »