Issue 2236843002: Do not rely on identical string constants having distinct pointers.

Issue 2236843002: Do not rely on identical string constants having distinct pointers. (Closed)

Created:
4 years, 4 months ago by grt (UTC plus 2)

Modified:
4 years, 4 months ago

Reviewers:
Reid Kleckner

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Do not rely on identical string constants having distinct pointers. BUG=635943 R=rnk@chromium.org Committed: https://crrev.com/e5c331861fe09a14c01bd70f70087c7b99c1df24 Cr-Commit-Position: refs/heads/master@{#411775}

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+25 lines, -30 lines)			Patch
M	chrome/tools/disable_outdated_build_detector/constants.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/tools/disable_outdated_build_detector/constants.cc	View	1 chunk	+0 lines, -9 lines	0 comments	Download
M	chrome/tools/disable_outdated_build_detector/disable_outdated_build_detector.cc	View	3 chunks	+8 lines, -10 lines	0 comments	Download
M	chrome/tools/disable_outdated_build_detector/google_update_integration.h	View	1 chunk	+8 lines, -4 lines	0 comments	Download
M	chrome/tools/disable_outdated_build_detector/google_update_integration.cc	View	2 chunks	+9 lines, -4 lines	0 comments	Download

Total messages: 12 (6 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2236843002/1

4 years, 4 months ago (2016-08-12 20:21:44 UTC) #8

commit-bot: I haz the power

4 years, 4 months ago (2016-08-12 21:30:01 UTC) #12

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/e5c331861fe09a14c01bd70f70087c7b99c1df24
Cr-Commit-Position: refs/heads/master@{#411775}