Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(832)

Side by Side Diff: chrome/tools/disable_outdated_build_detector/constants.h

Issue 2236843002: Do not rely on identical string constants having distinct pointers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/tools/disable_outdated_build_detector/constants.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_TOOLS_DISABLE_OUTDATED_BUILD_DETECTOR_CONSTANTS_H_ 5 #ifndef CHROME_TOOLS_DISABLE_OUTDATED_BUILD_DETECTOR_CONSTANTS_H_
6 #define CHROME_TOOLS_DISABLE_OUTDATED_BUILD_DETECTOR_CONSTANTS_H_ 6 #define CHROME_TOOLS_DISABLE_OUTDATED_BUILD_DETECTOR_CONSTANTS_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 namespace switches { 10 namespace switches {
11 11
12 extern const char kMultiInstall[]; 12 extern const char kMultiInstall[];
13 extern const char kSystemLevel[]; 13 extern const char kSystemLevel[];
14 14
15 } // namespace switches 15 } // namespace switches
16 16
17 namespace env { 17 namespace env {
18 18
19 extern const char kGoogleUpdateIsMachine[]; 19 extern const char kGoogleUpdateIsMachine[];
20 20
21 } // namespace env 21 } // namespace env
22 22
23 extern const wchar_t kChromeAppGuid[];
24 extern const wchar_t kBinariesAppGuid[];
25
26 extern const wchar_t kAOHY[]; 23 extern const wchar_t kAOHY[];
27 extern const wchar_t kBrand[]; 24 extern const wchar_t kBrand[];
28 extern const wchar_t kInstallerResult[]; 25 extern const wchar_t kInstallerResult[];
29 extern const wchar_t kInstallerError[]; 26 extern const wchar_t kInstallerError[];
30 extern const wchar_t kInstallerExtraCode1[]; 27 extern const wchar_t kInstallerExtraCode1[];
31 extern const wchar_t kUninstallArguments[]; 28 extern const wchar_t kUninstallArguments[];
32 29
33 // Values for the process exit code and for Google Update's InstallerError, 30 // Values for the process exit code and for Google Update's InstallerError,
34 // both of which are of type DWORD (a 32-bit unsigned int). The codes start at 31 // both of which are of type DWORD (a 32-bit unsigned int). The codes start at
35 // 1000 so as to not collide with existing setup.exe and mini_installer.exe 32 // 1000 so as to not collide with existing setup.exe and mini_installer.exe
(...skipping 16 matching lines...) Expand all
52 FAILED_READING_BRAND = 1013, // RegQueryValueEx failed. 49 FAILED_READING_BRAND = 1013, // RegQueryValueEx failed.
53 FAILED_WRITING_BRAND = 1014, // RegSetValueEx failed. 50 FAILED_WRITING_BRAND = 1014, // RegSetValueEx failed.
54 }; 51 };
55 52
56 // Values defined by Google Update. 53 // Values defined by Google Update.
57 enum class InstallerResult : uint32_t { 54 enum class InstallerResult : uint32_t {
58 FAILED_CUSTOM_ERROR = 1, 55 FAILED_CUSTOM_ERROR = 1,
59 }; 56 };
60 57
61 #endif // CHROME_TOOLS_DISABLE_OUTDATED_BUILD_DETECTOR_CONSTANTS_H_ 58 #endif // CHROME_TOOLS_DISABLE_OUTDATED_BUILD_DETECTOR_CONSTANTS_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/tools/disable_outdated_build_detector/constants.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698