Do not rely on identical string constants having distinct pointers.

chrome/tools/disable_outdated_build_detector/google_update_integration.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/tools/disable_outdated_build_detector/google_update_integration.h"
 
 #include "base/strings/string_util.h"
 #include "base/strings/stringprintf.h"
 #include "base/win/registry.h"
 
 uint32_t OpenClientStateKey(bool system_level,
-                            const wchar_t* app_guid,
+                            App app,
                             base::win::RegKey* key) {
 #if defined(GOOGLE_CHROME_BUILD)
+  constexpr wchar_t kChromeAppGuid[] =
+      L"{8A69D345-D564-463c-AFF1-A69D9E530F96}";
+  constexpr wchar_t kBinariesAppGuid[] =
+      L"{4DC8B4CA-1BDA-483e-B5FA-D3C12E15B62D}";
   base::string16 path(base::StringPrintf(
-      L"Software\\Google\\Update\\ClientState\\%ls", app_guid));
+      L"Software\\Google\\Update\\ClientState\\%ls",
+      (app == App::CHROME_BINARIES ? kBinariesAppGuid : kChromeAppGuid)));
 #else
-  base::string16 path(app_guid == kBinariesAppGuid
+  base::string16 path(app == App::CHROME_BINARIES
                           ? L"Software\\Chromium Binaries"
                           : L"Software\\Chromium");
 #endif
   return key->Open(system_level ? HKEY_LOCAL_MACHINE : HKEY_CURRENT_USER,
                    path.c_str(),
                    KEY_QUERY_VALUE | KEY_SET_VALUE | KEY_WOW64_32KEY);
 }
 
 void WriteResultInfo(bool system_level, const ResultInfo& result_info) {
   base::win::RegKey key;
-  uint32_t result = OpenClientStateKey(system_level, kChromeAppGuid, &key);
+  uint32_t result = OpenClientStateKey(system_level, App::CHROME_BROWSER, &key);
   if (result != ERROR_SUCCESS)
     return;
   key.WriteValue(kInstallerResult,
                  static_cast<uint32_t>(result_info.installer_result));
   key.WriteValue(kInstallerError,
                  static_cast<uint32_t>(result_info.installer_error));
   if (result_info.installer_extra_code1) {
     key.WriteValue(kInstallerExtraCode1,
                    static_cast<uint32_t>(result_info.installer_error));
   } else {
@@ skipping 14 matching lines @@
       L"ECWE", L"ECWF", L"EUBB", L"EUBC", L"GGLA", L"GGLS"};
   const wchar_t* const* end = &kBrands[arraysize(kBrands)];
   const wchar_t* const* found = std::find(&kBrands[0], end, brand);
   if (found != end)
     return true;
 
   return base::StartsWith(brand, L"EUB", base::CompareCase::SENSITIVE) ||
          base::StartsWith(brand, L"EUC", base::CompareCase::SENSITIVE) ||
          base::StartsWith(brand, L"GGR", base::CompareCase::SENSITIVE);
 }