chrome/tools/disable_outdated_build_detector/constants.cc - Issue 2236843002: Do not rely on identical string constants having distinct pointers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/tools/disable_outdated_build_detector/constants.cc

Issue 2236843002: Do not rely on identical string constants having distinct pointers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/tools/disable_outdated_build_detector/constants.h ('k') | chrome/tools/disable_outdated_build_detector/disable_outdated_build_detector.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/tools/disable_outdated_build_detector/constants.cc

diff --git a/chrome/tools/disable_outdated_build_detector/constants.cc b/chrome/tools/disable_outdated_build_detector/constants.cc

index 7d69c820136bb84aba5b074dd7a0fd5efef3a552..53d45beaba608988f3de324a650940d1fe0f5f01 100644

--- a/chrome/tools/disable_outdated_build_detector/constants.cc

+++ b/chrome/tools/disable_outdated_build_detector/constants.cc

@@ -20,15 +20,6 @@ const char kGoogleUpdateIsMachine[] = "GoogleUpdateIsMachine";

} // namespace env

-// App GUIDs for Google Chrome and the Google Chrome binaries.

-#if defined(GOOGLE_CHROME_BUILD)

-const wchar_t kChromeAppGuid[] = L"{8A69D345-D564-463c-AFF1-A69D9E530F96}";

-const wchar_t kBinariesAppGuid[] = L"{4DC8B4CA-1BDA-483e-B5FA-D3C12E15B62D}";

-#else

-const wchar_t kChromeAppGuid[] = L"";

-const wchar_t kBinariesAppGuid[] = L"";

-#endif

// The new brand to which organic installs will be switched.

const wchar_t kAOHY[] = L"AOHY";