Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Side by Side Diff: chrome/tools/disable_outdated_build_detector/google_update_integration.h

Issue 2236843002: Do not rely on identical string constants having distinct pointers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_TOOLS_DISABLE_OUTDATED_BUILD_DETECTOR_GOOGLE_UPDATE_INTEGRATION_H _ 5 #ifndef CHROME_TOOLS_DISABLE_OUTDATED_BUILD_DETECTOR_GOOGLE_UPDATE_INTEGRATION_H _
6 #define CHROME_TOOLS_DISABLE_OUTDATED_BUILD_DETECTOR_GOOGLE_UPDATE_INTEGRATION_H _ 6 #define CHROME_TOOLS_DISABLE_OUTDATED_BUILD_DETECTOR_GOOGLE_UPDATE_INTEGRATION_H _
7 7
8 #include "base/strings/string16.h" 8 #include "base/strings/string16.h"
9 #include "chrome/tools/disable_outdated_build_detector/constants.h" 9 #include "chrome/tools/disable_outdated_build_detector/constants.h"
10 10
11 namespace base { 11 namespace base {
12 namespace win { 12 namespace win {
13 class RegKey; 13 class RegKey;
14 } 14 }
15 } 15 }
16 16
17 // A structure containing the values that comprise the Google Update installer 17 // A structure containing the values that comprise the Google Update installer
18 // result API. 18 // result API.
19 struct ResultInfo { 19 struct ResultInfo {
20 InstallerResult installer_result; 20 InstallerResult installer_result;
21 ExitCode installer_error; 21 ExitCode installer_error;
22 uint32_t installer_extra_code1; 22 uint32_t installer_extra_code1;
23 }; 23 };
24 24
25 // An identifier of an app's registration with Google Update.
26 enum class App {
27 CHROME_BROWSER,
28 CHROME_BINARIES,
29 };
30
25 // Opens the Google Update ClientState key in the registry for the app 31 // Opens the Google Update ClientState key in the registry for the app
26 // identified by |app_guid| at |system_level|. Returns ERROR_SUCCESS or another 32 // identified by |app| at |system_level|. Returns ERROR_SUCCESS or another
27 // Windows error value. 33 // Windows error value.
28 uint32_t OpenClientStateKey(bool system_level, 34 uint32_t OpenClientStateKey(bool system_level, App app, base::win::RegKey* key);
29 const wchar_t* app_guid,
30 base::win::RegKey* key);
31 35
32 // Writes the data in |result_info| into Chrome's ClientState key. 36 // Writes the data in |result_info| into Chrome's ClientState key.
33 void WriteResultInfo(bool system_level, const ResultInfo& result_info); 37 void WriteResultInfo(bool system_level, const ResultInfo& result_info);
34 38
35 // Returns |true| if |brand| represents an organic brand code. 39 // Returns |true| if |brand| represents an organic brand code.
36 bool IsOrganic(const base::string16& brand); 40 bool IsOrganic(const base::string16& brand);
37 41
38 #endif // CHROME_TOOLS_DISABLE_OUTDATED_BUILD_DETECTOR_GOOGLE_UPDATE_INTEGRATIO N_H_ 42 #endif // CHROME_TOOLS_DISABLE_OUTDATED_BUILD_DETECTOR_GOOGLE_UPDATE_INTEGRATIO N_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698