chrome/tools/disable_outdated_build_detector/constants.h - Issue 2236843002: Do not rely on identical string constants having distinct pointers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/tools/disable_outdated_build_detector/constants.h

Issue 2236843002: Do not rely on identical string constants having distinct pointers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/tools/disable_outdated_build_detector/constants.h

diff --git a/chrome/tools/disable_outdated_build_detector/constants.h b/chrome/tools/disable_outdated_build_detector/constants.h

index 30b6eac82df9f7833471dcca60eeab87647434b0..be5085e22bbf3f323da8976fc4e6693a0d119841 100644

--- a/chrome/tools/disable_outdated_build_detector/constants.h

+++ b/chrome/tools/disable_outdated_build_detector/constants.h

@@ -20,9 +20,6 @@ extern const char kGoogleUpdateIsMachine[];

} // namespace env

-extern const wchar_t kChromeAppGuid[];

-extern const wchar_t kBinariesAppGuid[];

extern const wchar_t kAOHY[];

extern const wchar_t kBrand[];

extern const wchar_t kInstallerResult[];

« no previous file with comments | « no previous file | chrome/tools/disable_outdated_build_detector/constants.cc » ('j') | no next file with comments »