Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Unified Diff: chrome/tools/disable_outdated_build_detector/google_update_integration.h

Issue 2236843002: Do not rely on identical string constants having distinct pointers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/tools/disable_outdated_build_detector/google_update_integration.h
diff --git a/chrome/tools/disable_outdated_build_detector/google_update_integration.h b/chrome/tools/disable_outdated_build_detector/google_update_integration.h
index 7651354c4edd06ef5a45d7bc8d1b69f912adbc43..c8e150594bf44d10e4f9afbc8a9ba9b3a99c464b 100644
--- a/chrome/tools/disable_outdated_build_detector/google_update_integration.h
+++ b/chrome/tools/disable_outdated_build_detector/google_update_integration.h
@@ -22,12 +22,16 @@ struct ResultInfo {
uint32_t installer_extra_code1;
};
+// An identifier of an app's registration with Google Update.
+enum class App {
+ CHROME_BROWSER,
+ CHROME_BINARIES,
+};
+
// Opens the Google Update ClientState key in the registry for the app
-// identified by |app_guid| at |system_level|. Returns ERROR_SUCCESS or another
+// identified by |app| at |system_level|. Returns ERROR_SUCCESS or another
// Windows error value.
-uint32_t OpenClientStateKey(bool system_level,
- const wchar_t* app_guid,
- base::win::RegKey* key);
+uint32_t OpenClientStateKey(bool system_level, App app, base::win::RegKey* key);
// Writes the data in |result_info| into Chrome's ClientState key.
void WriteResultInfo(bool system_level, const ResultInfo& result_info);

Powered by Google App Engine
This is Rietveld 408576698