Re-land "WebGL: Transfer ownership of WebGraphicsContext3D to DrawingBuffer"

Re-land "WebGL: Transfer ownership of WebGraphicsContext3D to DrawingBuffer"

r168481 reverted r168457 "WebGL: Transfer ownership of WebGraphicsContext3D...",
which caused assertion failures on debug GPU bots. This CL relands the CL.

BUG=344393
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170970

[dshwang, 2014-04-03 09:17:08]

This CL was landed in https://codereview.chromium.org/163773007
but reverted in https://codereview.chromium.org/184343005
because of assertion fail;
https://code.google.com/p/chromium/issues/detail?id=344393#c6

The assertion fail is due to my mistake. I landed separate CL to make sure the
logic change about assertion; https://codereview.chromium.org/189423003

Could you re-review?

[Ken Russell (switch to Gerrit), 2014-04-06 06:07:23]

LGTM

Please make sure the GPU try jobs pass (I re-invoked them using the Rietveld UI;
see http://dev.chromium.org/developers/testing/gpu-testing for instructions on
invoking them via "git cl try"). Then make sure the GPU bots on
http://build.chromium.org/p/chromium.webkit/console are green before CQ'ing, and
then watch them after this lands. If any of them turn red as a result of this
change, please revert right away. Thanks.

https://codereview.chromium.org/223223003/diff/1/Source/core/html/canvas/WebG...
File Source/core/html/canvas/WebGLRenderingContextBase.cpp (right):

https://codereview.chromium.org/223223003/diff/1/Source/core/html/canvas/WebG...
Source/core/html/canvas/WebGLRenderingContextBase.cpp:5371: // If the context
was lost due to RealLostContext, we need to destruct the old DrawingBuffer
before creating new DrawingBuffer to ensure resource budget enough.
destruct -> destroy

[dshwang, 2014-04-07 13:49:12]

On 2014/04/06 06:07:23, Ken Russell wrote:
> LGTM

Thank you for review.

> Please make sure the GPU try jobs pass (I re-invoked them using the Rietveld
UI;
> see http://dev.chromium.org/developers/testing/gpu-testing for instructions on
> invoking them via "git cl try"). Then make sure the GPU bots on
> http://build.chromium.org/p/chromium.webkit/console are green before CQ'ing,
and
> then watch them after this lands. If any of them turn red as a result of this
> change, please revert right away. Thanks.

Thank you for nice explanation about gpu bots. I'll keep eyes on red.

>
https://codereview.chromium.org/223223003/diff/1/Source/core/html/canvas/WebG...
> File Source/core/html/canvas/WebGLRenderingContextBase.cpp (right):
> 
>
https://codereview.chromium.org/223223003/diff/1/Source/core/html/canvas/WebG...
> Source/core/html/canvas/WebGLRenderingContextBase.cpp:5371: // If the context
> was lost due to RealLostContext, we need to destruct the old DrawingBuffer
> before creating new DrawingBuffer to ensure resource budget enough.
> destruct -> destroy

Done.

[dshwang, 2014-04-07 13:49:15]

The CQ bit was checked by dongseong.hwang@intel.com

[commit-bot: I haz the power, 2014-04-07 13:49:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dongseong.hwang@intel.com/223223003/10001

[commit-bot: I haz the power, 2014-04-07 13:58:38]

Change committed as 170970