Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(635)

Issue 2226643004: QuicSession no longer directly owns its QuicConnection. Not flag protected. (Closed)

Created:
4 years, 4 months ago by danzh1
Modified:
4 years, 4 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@129226757
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

QuicSession no longer directly owns its QuicConnection. Not flag protected. Merge internal change: 129318081 R=rch@chromium.org BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -15 lines) Patch
M net/quic/core/quic_client_session_base.h View 1 chunk +2 lines, -1 line 0 comments Download
M net/quic/core/quic_client_session_base.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/core/quic_server_session_base.h View 1 chunk +2 lines, -1 line 0 comments Download
M net/quic/core/quic_server_session_base_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/quic_session.h View 3 chunks +4 lines, -4 lines 0 comments Download
M net/quic/core/quic_session.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/quic/core/quic_session_test.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M net/quic/core/quic_spdy_session.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.h View 3 chunks +3 lines, -0 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.cc View 3 chunks +9 lines, -3 lines 0 comments Download
M net/tools/quic/quic_client_base.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/tools/quic/quic_client_session.h View 1 chunk +2 lines, -1 line 0 comments Download
M net/tools/quic/quic_dispatcher_test.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/tools/quic/quic_simple_server_session.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/tools/quic/quic_simple_server_session.cc View 1 chunk +3 lines, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 6 (4 generated)
danzh1
4 years, 4 months ago (2016-08-08 21:06:44 UTC) #1
Ryan Hamilton
4 years, 4 months ago (2016-08-09 16:33:15 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698