net/quic/core/quic_client_session_base.h - Issue 2226643004: QuicSession no longer directly owns its QuicConnection. Not flag protected.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/core/quic_client_session_base.h

Issue 2226643004: QuicSession no longer directly owns its QuicConnection. Not flag protected. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@129226757

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/quic/core/quic_client_session_base.h

diff --git a/net/quic/core/quic_client_session_base.h b/net/quic/core/quic_client_session_base.h

index 948f65a33f713d76b76c2108c7bb62bc292030dc..0fcf8875a41c32daedc3a296acfce2a759ceb65c 100644

--- a/net/quic/core/quic_client_session_base.h

+++ b/net/quic/core/quic_client_session_base.h

@@ -35,7 +35,8 @@ class NET_EXPORT_PRIVATE QuicClientSessionBase

: public QuicSpdySession,

public QuicCryptoClientStream::ProofHandler {

public:

- // Caller retains ownership of |promised_by_url|.

+ // Takes ownership of |connection|. Caller retains ownership of

+ // |promised_by_url|.

QuicClientSessionBase(QuicConnection* connection,

QuicClientPushPromiseIndex* push_promise_index,

const QuicConfig& config);

« no previous file with comments | « no previous file | net/quic/core/quic_client_session_base.cc » ('j') | no next file with comments »