net/tools/quic/quic_dispatcher_test.cc - Issue 2226643004: QuicSession no longer directly owns its QuicConnection. Not flag protected.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/tools/quic/quic_dispatcher_test.cc

Issue 2226643004: QuicSession no longer directly owns its QuicConnection. Not flag protected. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@129226757

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/tools/quic/quic_dispatcher_test.cc

diff --git a/net/tools/quic/quic_dispatcher_test.cc b/net/tools/quic/quic_dispatcher_test.cc

index 967474df0d683b0f8a1e6a1294a13c3271cb60c4..032f660d60112579cc750b0c24bdd158c3cd80f1 100644

--- a/net/tools/quic/quic_dispatcher_test.cc

+++ b/net/tools/quic/quic_dispatcher_test.cc

@@ -61,7 +61,8 @@ class TestQuicSpdyServerSession : public QuicServerSessionBase {

crypto_config,

compressed_certs_cache),

crypto_stream_(QuicServerSessionBase::GetCryptoStream()) {}

- ~TestQuicSpdyServerSession() override{};

+ ~TestQuicSpdyServerSession() override { delete connection(); };

MOCK_METHOD3(OnConnectionClosed,

void(QuicErrorCode error,

« no previous file with comments | « net/tools/quic/quic_client_session.h ('k') | net/tools/quic/quic_simple_server_session.h » ('j') | no next file with comments »