Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Unified Diff: net/quic/test_tools/quic_test_utils.h

Issue 2226643004: QuicSession no longer directly owns its QuicConnection. Not flag protected. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@129226757
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/core/quic_spdy_session.h ('k') | net/quic/test_tools/quic_test_utils.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/test_tools/quic_test_utils.h
diff --git a/net/quic/test_tools/quic_test_utils.h b/net/quic/test_tools/quic_test_utils.h
index f7d148d0667a52c6e7f1f52a898f62caaf31d2af..fb5ed36b6a57616b40ea21f11c182ca98ec2d7c8 100644
--- a/net/quic/test_tools/quic_test_utils.h
+++ b/net/quic/test_tools/quic_test_utils.h
@@ -498,6 +498,7 @@ class PacketSavingConnection : public MockQuicConnection {
class MockQuicSession : public QuicSession {
public:
+ // Takes ownership of |connection|.
explicit MockQuicSession(QuicConnection* connection);
~MockQuicSession() override;
@@ -554,6 +555,7 @@ class MockQuicSession : public QuicSession {
class MockQuicSpdySession : public QuicSpdySession {
public:
+ // Takes ownership of |connection|.
explicit MockQuicSpdySession(QuicConnection* connection);
~MockQuicSpdySession() override;
@@ -640,6 +642,7 @@ class MockQuicSpdySession : public QuicSpdySession {
class TestQuicSpdyServerSession : public QuicServerSessionBase {
public:
+ // Takes ownership of |connection|.
TestQuicSpdyServerSession(QuicConnection* connection,
const QuicConfig& config,
const QuicCryptoServerConfig* crypto_config,
« no previous file with comments | « net/quic/core/quic_spdy_session.h ('k') | net/quic/test_tools/quic_test_utils.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698