Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Issue 2222393002: Make QuicDispatcher to queue packets for new connections while waiting for CHLOs. Flag protected by… (Closed)

Created:
4 years, 4 months ago by danzh1
Modified:
4 years, 4 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@129318081
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make QuicDispatcher to queue packets for new connections while waiting for CHLOs. Flag protected by --quic_buffer_packet_till_chlo Merge internal change: 129327247 R=rch@chromium.org BUG=

Patch Set 1 #

Patch Set 2 : add new files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+891 lines, -152 lines) Patch
M net/net.gypi View 1 2 chunks +4 lines, -0 lines 0 comments Download
M net/quic/core/quic_buffered_packet_store_test.cc View 2 chunks +1 line, -7 lines 0 comments Download
M net/quic/core/quic_flags.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/core/quic_flags.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M net/quic/test_tools/crypto_test_utils.h View 2 chunks +14 lines, -0 lines 0 comments Download
M net/quic/test_tools/crypto_test_utils.cc View 2 chunks +52 lines, -0 lines 0 comments Download
A net/quic/test_tools/quic_buffered_packet_store_peer.h View 1 1 chunk +33 lines, -0 lines 0 comments Download
A net/quic/test_tools/quic_buffered_packet_store_peer.cc View 1 1 chunk +25 lines, -0 lines 0 comments Download
M net/tools/quic/chlo_extractor.cc View 1 chunk +3 lines, -1 line 0 comments Download
M net/tools/quic/end_to_end_test.cc View 12 chunks +148 lines, -73 lines 0 comments Download
M net/tools/quic/quic_dispatcher.h View 5 chunks +25 lines, -3 lines 0 comments Download
M net/tools/quic/quic_dispatcher.cc View 7 chunks +83 lines, -23 lines 0 comments Download
M net/tools/quic/quic_dispatcher_test.cc View 1 24 chunks +395 lines, -45 lines 0 comments Download
A net/tools/quic/test_tools/packet_reordering_writer.h View 1 1 chunk +45 lines, -0 lines 0 comments Download
A net/tools/quic/test_tools/packet_reordering_writer.cc View 1 1 chunk +50 lines, -0 lines 0 comments Download
M net/tools/quic/test_tools/quic_dispatcher_peer.h View 1 chunk +3 lines, -0 lines 0 comments Download
M net/tools/quic/test_tools/quic_dispatcher_peer.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 12 (8 generated)
danzh1
4 years, 4 months ago (2016-08-09 15:53:07 UTC) #1
Ryan Hamilton
lgtm
4 years, 4 months ago (2016-08-09 16:42:12 UTC) #6
danzh1
On 2016/08/09 16:42:12, Ryan Hamilton wrote: > lgtm Forgot to commit newly added files. PTAL!
4 years, 4 months ago (2016-08-09 20:51:12 UTC) #9
Ryan Hamilton
4 years, 4 months ago (2016-08-09 21:54:43 UTC) #12
On 2016/08/09 20:51:12, danzh1 wrote:
> On 2016/08/09 16:42:12, Ryan Hamilton wrote:
> > lgtm
> 
> Forgot to commit newly added files. PTAL!

Hah! I've done that myself many times. LGTM

Powered by Google App Engine
This is Rietveld 408576698