Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2320)

Unified Diff: net/quic/test_tools/quic_test_utils.cc

Issue 2226643004: QuicSession no longer directly owns its QuicConnection. Not flag protected. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@129226757
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/test_tools/quic_test_utils.h ('k') | net/tools/quic/quic_client_base.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/test_tools/quic_test_utils.cc
diff --git a/net/quic/test_tools/quic_test_utils.cc b/net/quic/test_tools/quic_test_utils.cc
index d447126bcf7011a6c78253aadef6e25f6b286ae2..30e1f020888471669e4f333a821d67039f68d811 100644
--- a/net/quic/test_tools/quic_test_utils.cc
+++ b/net/quic/test_tools/quic_test_utils.cc
@@ -350,7 +350,9 @@ MockQuicSession::MockQuicSession(QuicConnection* connection)
.WillByDefault(testing::Return(QuicConsumedData(0, false)));
}
-MockQuicSession::~MockQuicSession() {}
+MockQuicSession::~MockQuicSession() {
+ delete connection();
+}
// static
QuicConsumedData MockQuicSession::ConsumeAllData(
@@ -371,7 +373,9 @@ MockQuicSpdySession::MockQuicSpdySession(QuicConnection* connection)
.WillByDefault(testing::Return(QuicConsumedData(0, false)));
}
-MockQuicSpdySession::~MockQuicSpdySession() {}
+MockQuicSpdySession::~MockQuicSpdySession() {
+ delete connection();
+}
TestQuicSpdyServerSession::TestQuicSpdyServerSession(
QuicConnection* connection,
@@ -392,7 +396,9 @@ TestQuicSpdyServerSession::TestQuicSpdyServerSession(
.WillByDefault(testing::Return(true));
}
-TestQuicSpdyServerSession::~TestQuicSpdyServerSession() {}
+TestQuicSpdyServerSession::~TestQuicSpdyServerSession() {
+ delete connection();
+}
QuicCryptoServerStreamBase*
TestQuicSpdyServerSession::CreateQuicCryptoServerStream(
« no previous file with comments | « net/quic/test_tools/quic_test_utils.h ('k') | net/tools/quic/quic_client_base.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698