net/quic/core/quic_server_session_base_test.cc - Issue 2226643004: QuicSession no longer directly owns its QuicConnection. Not flag protected.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/core/quic_server_session_base_test.cc

Issue 2226643004: QuicSession no longer directly owns its QuicConnection. Not flag protected. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@129226757

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/quic/core/quic_server_session_base_test.cc

diff --git a/net/quic/core/quic_server_session_base_test.cc b/net/quic/core/quic_server_session_base_test.cc

index 00b83cdd160f3444eb82723fb15e3f97fb426f8e..8682a8db4e0dc282e874eec0eecd85562a226004 100644

--- a/net/quic/core/quic_server_session_base_test.cc

+++ b/net/quic/core/quic_server_session_base_test.cc

@@ -86,7 +86,7 @@ class TestServerSession : public QuicServerSessionBase {

crypto_config,

compressed_certs_cache) {}

- ~TestServerSession() override{};

+ ~TestServerSession() override { delete connection(); };

protected:

QuicSpdyStream* CreateIncomingDynamicStream(QuicStreamId id) override {

« no previous file with comments | « net/quic/core/quic_server_session_base.h ('k') | net/quic/core/quic_session.h » ('j') | no next file with comments »