Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 221783002: Revert of gpu: Raise GL_OUT_OF_MEMORY when BeginQueryEXT fails to allocate. (Closed)

Created:
6 years, 8 months ago by pfeldman
Modified:
6 years, 8 months ago
CC:
chromium-reviews, piman+watch_chromium.org, jamesr, no sievers, vmiura
Visibility:
Public.

Description

Revert of gpu: Raise GL_OUT_OF_MEMORY when BeginQueryEXT fails to allocate. (https://codereview.chromium.org/199443004/) Reason for revert: Build failure in content/common/gpu/client/gl_helper_benchmark.cc. http://build.chromium.org/p/chromium/builders/Linux%20x64/builds/63241/steps/compile/logs/stdio Original issue's description: > gpu: Lose context when BeginQueryEXT fails to allocate. > > Instead of crashes, raise a GL_OUT_OF_MEMORY error. Since compositor > does not want to deal with these errors and it would leave it in a > bad state, add the ability to lose the context when GL_OUT_OF_MEMORY > occurs. > > R=piman > BUG=351587 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261064 TBR=piman@chromium.org,dmichael@chromium.org,jamesr@chromium.org,danakj@chromium.org NOTREECHECKS=true NOTRY=true BUG=351587 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261075

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1036 lines, -861 lines) Patch
M content/browser/android/in_process/synchronous_compositor_factory_impl.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M content/browser/compositor/gpu_process_transport_factory.cc View 2 chunks +1 line, -4 lines 0 comments Download
M content/browser/gpu/gpu_ipc_browsertests.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M content/browser/renderer_host/compositor_impl_android.cc View 1 chunk +1 line, -4 lines 0 comments Download
M content/browser/renderer_host/image_transport_factory_android.cc View 1 chunk +1 line, -4 lines 0 comments Download
M content/common/gpu/client/context_provider_command_buffer_browsertest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M content/common/gpu/client/gl_helper_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/common/gpu/client/gpu_in_process_context_tests.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.h View 4 chunks +14 lines, -18 lines 0 comments Download
M content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.cc View 6 chunks +13 lines, -22 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 3 chunks +1 line, -6 lines 0 comments Download
M content/renderer/render_widget.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/render_widget.cc View 4 chunks +28 lines, -28 lines 0 comments Download
M content/renderer/renderer_webkitplatformsupport_impl.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/test/test_context_provider_factory.cc View 1 chunk +1 line, -3 lines 0 comments Download
M gpu/command_buffer/client/gl_in_process_context.h View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/command_buffer/client/gl_in_process_context.cc View 4 chunks +1 line, -9 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation.h View 3 chunks +11 lines, -9 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation.cc View 5 chunks +16 lines, -15 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation_unittest.cc View 7 chunks +11 lines, -63 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_utils.h View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/command_buffer/common/gles2_cmd_utils.cc View 3 chunks +13 lines, -19 lines 0 comments Download
M gpu/command_buffer/service/context_state.h View 2 chunks +1 line, -4 lines 0 comments Download
M gpu/command_buffer/service/context_state.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M gpu/command_buffer/service/error_state.h View 1 chunk +1 line, -6 lines 0 comments Download
M gpu/command_buffer/service/error_state.cc View 4 chunks +8 lines, -10 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 7 chunks +2 lines, -21 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc View 84 chunks +775 lines, -441 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.h View 3 chunks +23 lines, -20 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc View 7 chunks +61 lines, -49 lines 0 comments Download
M gpu/command_buffer/tests/gl_manager.h View 1 chunk +0 lines, -2 lines 0 comments Download
M gpu/command_buffer/tests/gl_manager.cc View 2 chunks +8 lines, -9 lines 0 comments Download
M gpu/gles2_conform_support/egl/display.cc View 1 chunk +7 lines, -9 lines 0 comments Download
M mojo/examples/aura_demo/demo_context_factory.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M mojo/gles2/gles2_context.cc View 1 chunk +1 line, -6 lines 0 comments Download
M ppapi/shared_impl/ppb_graphics_3d_shared.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M ui/compositor/test/in_process_context_factory.cc View 3 chunks +3 lines, -8 lines 0 comments Download
M webkit/common/gpu/context_provider_in_process.h View 1 chunk +3 lines, -3 lines 0 comments Download
M webkit/common/gpu/context_provider_in_process.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M webkit/common/gpu/webgraphicscontext3d_in_process_command_buffer_impl.h View 3 chunks +1 line, -5 lines 0 comments Download
M webkit/common/gpu/webgraphicscontext3d_in_process_command_buffer_impl.cc View 5 chunks +13 lines, -28 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
pfeldman
Created Revert of gpu: Raise GL_OUT_OF_MEMORY when BeginQueryEXT fails to allocate.
6 years, 8 months ago (2014-04-02 04:54:37 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pfeldman@chromium.org/221783002/1
6 years, 8 months ago (2014-04-02 04:55:01 UTC) #2
commit-bot: I haz the power
6 years, 8 months ago (2014-04-02 04:56:21 UTC) #3
Message was sent while issue was closed.
Change committed as 261075

Powered by Google App Engine
This is Rietveld 408576698