Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 2217763003: Remove Blink-WebKit-only document.createEvent strings (Closed)

Created:
4 years, 4 months ago by foolip
Modified:
4 years, 3 months ago
Reviewers:
Rick Byers
CC:
chromium-reviews, dominickn+watch_chromium.org, tzik, johnme+watch_chromium.org, eae+blinkwatch, eric.carlson_apple.com, apavlov+blink_chromium.org, rwlbuis, jsbell+serviceworker_chromium.org, Yoav Weiss, toyoshim+midi_chromium.org, iclelland+watch_chromium.org, blink-reviews-css, chasej+watch_chromium.org, dglazkov+blink, jkarlin+watch_chromium.org, blink-reviews, harkness+watch_chromium.org, mcasas+watch+mediastream_chromium.org, kenneth.christiansen, blink-reviews-w3ctests_chromium.org, Peter Beverloo, nhiroki, feature-media-reviews_chromium.org, tommyw+watchlist_chromium.org, mcasas+watch+mediarecorder_chromium.org, darktears, haraken, michaeln, dtapuska+blinkwatch_chromium.org, emircan+watch+mediarecorder_chromium.org, mlamouri+watch-blink_chromium.org, tfarina, serviceworker-reviews, falken, blink-reviews-events_chromium.org, kinuko+serviceworker, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove Blink-WebKit-only document.createEvent strings Intent to Deprecate and Remove: https://groups.google.com/a/chromium.org/d/msg/blink-dev/BkPSl0Oey8k/BqJ3_ck0BAAJ BUG=569690 Committed: https://crrev.com/44f23455c950be91f4626c6c600e009cd4b1480c Cr-Commit-Position: refs/heads/master@{#415678}

Patch Set 1 #

Patch Set 2 : WebKit strings too #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -510 lines) Patch
D third_party/WebKit/LayoutTests/fast/dom/Orientation/create-event-orientationchange.html View 1 1 chunk +0 lines, -11 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Orientation/create-event-orientationchange-expected.txt View 1 1 chunk +0 lines, -9 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Orientation/script-tests/create-event-orientationchange.js View 1 1 chunk +0 lines, -20 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/events/event-creation.html View 1 2 chunks +0 lines, -21 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/dom/nodes/Document-createEvent-expected.txt View 1 5 chunks +33 lines, -99 lines 0 comments Download
M third_party/WebKit/Source/build/scripts/make_event_factory.py View 1 1 chunk +0 lines, -34 lines 0 comments Download
M third_party/WebKit/Source/core/css/FontFaceSetLoadEvent.h View 2 chunks +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/css/FontFaceSetLoadEvent.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/css/MediaQueryListEvent.h View 2 chunks +0 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/events/ApplicationCacheErrorEvent.h View 2 chunks +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/events/ApplicationCacheErrorEvent.cpp View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/events/ClipboardEvent.h View 2 chunks +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/events/ClipboardEvent.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/events/EventAliases.in View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/events/PromiseRejectionEvent.h View 2 chunks +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/events/PromiseRejectionEvent.cpp View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/events/ResourceProgressEvent.h View 2 chunks +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/events/ResourceProgressEvent.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/events/SecurityPolicyViolationEvent.h View 2 chunks +0 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 2 2 chunks +0 lines, -34 lines 0 comments Download
M third_party/WebKit/Source/modules/app_banner/BeforeInstallPromptEvent.h View 2 chunks +0 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/modules/app_banner/BeforeInstallPromptEvent.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/background_sync/SyncEvent.h View 2 chunks +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/background_sync/SyncEvent.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/encryptedmedia/MediaEncryptedEvent.h View 2 chunks +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/modules/encryptedmedia/MediaEncryptedEvent.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/gamepad/GamepadEvent.h View 2 chunks +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/gamepad/GamepadEvent.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/mediarecorder/BlobEvent.h View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/mediarecorder/BlobEvent.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/modules/mediastream/MediaStreamEvent.h View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/mediastream/MediaStreamEvent.cpp View 3 chunks +0 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/modules/mediastream/MediaStreamTrackEvent.h View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/mediastream/MediaStreamTrackEvent.cpp View 1 chunk +0 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/modules/notifications/NotificationEvent.h View 2 chunks +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/notifications/NotificationEvent.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/peerconnection/RTCDTMFToneChangeEvent.h View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/peerconnection/RTCDTMFToneChangeEvent.cpp View 3 chunks +0 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/modules/peerconnection/RTCDataChannelEvent.h View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/peerconnection/RTCDataChannelEvent.cpp View 1 chunk +0 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/modules/peerconnection/RTCIceCandidateEvent.h View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/peerconnection/RTCIceCandidateEvent.cpp View 2 chunks +0 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/modules/presentation/PresentationConnectionAvailableEvent.h View 2 chunks +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/presentation/PresentationConnectionAvailableEvent.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/presentation/PresentationConnectionCloseEvent.h View 2 chunks +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/modules/push_messaging/PushEvent.h View 2 chunks +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/push_messaging/PushEvent.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/ExtendableEvent.h View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/ExtendableEvent.cpp View 2 chunks +0 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/ExtendableMessageEvent.h View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/ExtendableMessageEvent.cpp View 2 chunks +0 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/FetchEvent.h View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/FetchEvent.cpp View 2 chunks +0 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerMessageEvent.h View 2 chunks +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerMessageEvent.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/speech/SpeechRecognitionError.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/speech/SpeechRecognitionError.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/speech/SpeechRecognitionEvent.h View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/speech/SpeechRecognitionEvent.cpp View 2 chunks +0 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/modules/webmidi/MIDIConnectionEvent.h View 2 chunks +0 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/modules/webmidi/MIDIMessageEvent.h View 2 chunks +0 lines, -8 lines 0 comments Download

Messages

Total messages: 19 (14 generated)
foolip
PTAL
4 years, 3 months ago (2016-08-31 12:30:23 UTC) #9
Rick Byers
LGTM, thanks!
4 years, 3 months ago (2016-08-31 13:59:53 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2217763003/40001
4 years, 3 months ago (2016-08-31 17:50:23 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-08-31 17:57:17 UTC) #17
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 17:58:54 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/44f23455c950be91f4626c6c600e009cd4b1480c
Cr-Commit-Position: refs/heads/master@{#415678}

Powered by Google App Engine
This is Rietveld 408576698