third_party/WebKit/Source/modules/serviceworkers/FetchEvent.cpp - Issue 2217763003: Remove Blink-WebKit-only document.createEvent strings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/serviceworkers/FetchEvent.cpp

Issue 2217763003: Remove Blink-WebKit-only document.createEvent strings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/serviceworkers/FetchEvent.h ('k') | third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerMessageEvent.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/serviceworkers/FetchEvent.cpp

diff --git a/third_party/WebKit/Source/modules/serviceworkers/FetchEvent.cpp b/third_party/WebKit/Source/modules/serviceworkers/FetchEvent.cpp

index 47bf72a9f6bae25a26d291c738e373a9031403ef..3d7e5a73b1b73ef3eb732c92e878da75bf3b02e1 100644

--- a/third_party/WebKit/Source/modules/serviceworkers/FetchEvent.cpp

+++ b/third_party/WebKit/Source/modules/serviceworkers/FetchEvent.cpp

@@ -12,11 +12,6 @@

namespace blink {

-FetchEvent* FetchEvent::create()

- return new FetchEvent();

FetchEvent* FetchEvent::create(ScriptState* scriptState, const AtomicString& type, const FetchEventInit& initializer)

{

return new FetchEvent(scriptState, type, initializer, nullptr, nullptr);

@@ -54,11 +49,6 @@ const AtomicString& FetchEvent::interfaceName() const

return EventNames::FetchEvent;

}

-FetchEvent::FetchEvent()

- : m_isReload(false)

FetchEvent::FetchEvent(ScriptState* scriptState, const AtomicString& type, const FetchEventInit& initializer, RespondWithObserver* respondWithObserver, WaitUntilObserver* waitUntilObserver)

: ExtendableEvent(type, initializer, waitUntilObserver)

, m_observer(respondWithObserver)