third_party/WebKit/Source/modules/push_messaging/PushEvent.h - Issue 2217763003: Remove Blink-WebKit-only document.createEvent strings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/push_messaging/PushEvent.h

Issue 2217763003: Remove Blink-WebKit-only document.createEvent strings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/presentation/PresentationConnectionCloseEvent.h ('k') | third_party/WebKit/Source/modules/push_messaging/PushEvent.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/push_messaging/PushEvent.h

diff --git a/third_party/WebKit/Source/modules/push_messaging/PushEvent.h b/third_party/WebKit/Source/modules/push_messaging/PushEvent.h

index 1446a1068ea2a2f166683fb3ca434e8cb8d94cbd..009db175188f1a88ad6f3bde4abecd1fecefe62b 100644

--- a/third_party/WebKit/Source/modules/push_messaging/PushEvent.h

+++ b/third_party/WebKit/Source/modules/push_messaging/PushEvent.h

@@ -20,10 +20,6 @@ class PushEventInit;

class MODULES_EXPORT PushEvent final : public ExtendableEvent {

DEFINE_WRAPPERTYPEINFO();

public:

- static PushEvent* create()

- {

- return new PushEvent;

- }

static PushEvent* create(const AtomicString& type, PushMessageData* data, WaitUntilObserver* observer)

{

return new PushEvent(type, data, observer);

@@ -42,7 +38,6 @@ public:

DECLARE_VIRTUAL_TRACE();

private:

- PushEvent();

PushEvent(const AtomicString& type, PushMessageData*, WaitUntilObserver*);

PushEvent(const AtomicString& type, const PushEventInit&);