third_party/WebKit/Source/modules/notifications/NotificationEvent.h - Issue 2217763003: Remove Blink-WebKit-only document.createEvent strings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/notifications/NotificationEvent.h

Issue 2217763003: Remove Blink-WebKit-only document.createEvent strings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/mediastream/MediaStreamTrackEvent.cpp ('k') | third_party/WebKit/Source/modules/notifications/NotificationEvent.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/notifications/NotificationEvent.h

diff --git a/third_party/WebKit/Source/modules/notifications/NotificationEvent.h b/third_party/WebKit/Source/modules/notifications/NotificationEvent.h

index 1d08014219b7ea82193f6a1abe28ef4253f4d055..d454b127b9edc9c75fb75e72d32f521856c886a5 100644

--- a/third_party/WebKit/Source/modules/notifications/NotificationEvent.h

+++ b/third_party/WebKit/Source/modules/notifications/NotificationEvent.h

@@ -18,10 +18,6 @@ class NotificationEventInit;

class MODULES_EXPORT NotificationEvent final : public ExtendableEvent {

DEFINE_WRAPPERTYPEINFO();

public:

- static NotificationEvent* create()

- {

- return new NotificationEvent;

- }

static NotificationEvent* create(const AtomicString& type, const NotificationEventInit& initializer)

{

return new NotificationEvent(type, initializer);

@@ -41,7 +37,6 @@ public:

DECLARE_VIRTUAL_TRACE();

private:

- NotificationEvent();

NotificationEvent(const AtomicString& type, const NotificationEventInit&);

NotificationEvent(const AtomicString& type, const NotificationEventInit&, WaitUntilObserver*);