third_party/WebKit/Source/modules/app_banner/BeforeInstallPromptEvent.h - Issue 2217763003: Remove Blink-WebKit-only document.createEvent strings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/app_banner/BeforeInstallPromptEvent.h

Issue 2217763003: Remove Blink-WebKit-only document.createEvent strings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/frame/UseCounter.h ('k') | third_party/WebKit/Source/modules/app_banner/BeforeInstallPromptEvent.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/app_banner/BeforeInstallPromptEvent.h

diff --git a/third_party/WebKit/Source/modules/app_banner/BeforeInstallPromptEvent.h b/third_party/WebKit/Source/modules/app_banner/BeforeInstallPromptEvent.h

index dcc5bbe58eb3e2eaeae768f9bc2cb6134f59e86c..403349f60b0ad88662146bc8295e0fb5b3eb3a79 100644

--- a/third_party/WebKit/Source/modules/app_banner/BeforeInstallPromptEvent.h

+++ b/third_party/WebKit/Source/modules/app_banner/BeforeInstallPromptEvent.h

@@ -24,12 +24,6 @@ class BeforeInstallPromptEvent final : public Event {

public:

~BeforeInstallPromptEvent() override;

- // For EventModules.cpp

- static BeforeInstallPromptEvent* create()

- {

- return new BeforeInstallPromptEvent();

- }

static BeforeInstallPromptEvent* create(const AtomicString& name, ExecutionContext* executionContext, const Vector<String>& platforms, int requestId, WebAppBannerClient* client)

{

return new BeforeInstallPromptEvent(name, executionContext, platforms, requestId, client);

@@ -50,7 +44,6 @@ public:

DECLARE_VIRTUAL_TRACE();

private:

- BeforeInstallPromptEvent();

BeforeInstallPromptEvent(const AtomicString& name, ExecutionContext*, const Vector<String>& platforms, int requestId, WebAppBannerClient*);

BeforeInstallPromptEvent(const AtomicString& name, const BeforeInstallPromptEventInit&);