Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(730)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2215153002: [DevTools] Eliminate frameId and isContentScript from js protocol. (Closed)

Created:
4 years, 4 months ago by dgozman
Modified:
3 years, 10 months ago
Reviewers:
kozy, samuong, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Eliminate frameId and isContentScript from js protocol. Replaced with auxData supplied by embedder. BUG=631162 Committed: https://crrev.com/be29687013b17e0a1280414e4152f567091ab3bc Cr-Commit-Position: refs/heads/master@{#410239}

Patch Set 1 #

Patch Set 2 : include #

Total comments: 2

Patch Set 3 : object #

Patch Set 4 : regex, chromedriver #

Total comments: 2

Patch Set 5 : chromedriver #

Total comments: 2

Patch Set 6 : navigation tracker #

Unified diffs Side-by-side diffs Delta from patch set Stats (+144 lines, -82 lines) Patch
M chrome/test/chromedriver/chrome/frame_tracker.cc View 1 2 3 4 1 chunk +27 lines, -9 lines 0 comments Download
M chrome/test/chromedriver/chrome/frame_tracker_unittest.cc View 1 2 3 1 chunk +22 lines, -0 lines 0 comments Download
M chrome/test/chromedriver/chrome/navigation_tracker.cc View 1 2 3 4 5 1 chunk +5 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/last-execution-context.html View 3 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp View 2 chunks +10 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js View 4 chunks +11 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/generate-inspector-protocol-version View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/DebuggerScript.js View 1 2 3 3 chunks +17 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/InspectedContext.h View 2 chunks +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/InspectedContext.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8Debugger.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp View 1 2 3 chunks +7 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8DebuggerScript.h View 2 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8DebuggerScript.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp View 1 2 2 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/debugger_script_externs.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/js_protocol.json View 1 2 3 4 6 chunks +8 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/public/SimpleInspector.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/public/V8ContextInfo.h View 2 chunks +5 lines, -10 lines 0 comments Download

Messages

Total messages: 22 (9 generated)
dgozman
Could you please take a look?
4 years, 4 months ago (2016-08-04 22:51:39 UTC) #2
kozy
https://codereview.chromium.org/2215153002/diff/20001/third_party/WebKit/Source/platform/v8_inspector/DebuggerScript.js File third_party/WebKit/Source/platform/v8_inspector/DebuggerScript.js (right): https://codereview.chromium.org/2215153002/diff/20001/third_party/WebKit/Source/platform/v8_inspector/DebuggerScript.js#newcode162 third_party/WebKit/Source/platform/v8_inspector/DebuggerScript.js:162: var firstComma = contextData.indexOf(","); Can we use regexp here? ...
4 years, 4 months ago (2016-08-05 02:35:41 UTC) #3
dgozman
PTAL https://codereview.chromium.org/2215153002/diff/20001/third_party/WebKit/Source/platform/v8_inspector/DebuggerScript.js File third_party/WebKit/Source/platform/v8_inspector/DebuggerScript.js (right): https://codereview.chromium.org/2215153002/diff/20001/third_party/WebKit/Source/platform/v8_inspector/DebuggerScript.js#newcode162 third_party/WebKit/Source/platform/v8_inspector/DebuggerScript.js:162: var firstComma = contextData.indexOf(","); On 2016/08/05 02:35:41, kozyatinskiy ...
4 years, 4 months ago (2016-08-05 18:00:38 UTC) #8
dgozman
Sam, could you please take a look at chromedriver?
4 years, 4 months ago (2016-08-05 18:01:01 UTC) #10
kozy
lgtm
4 years, 4 months ago (2016-08-05 18:30:54 UTC) #11
samuong
Thanks! You'll also need to do the same thing in NavigationTracker::OnEvent, where it handles the ...
4 years, 4 months ago (2016-08-05 19:47:57 UTC) #12
dgozman
PTAL https://codereview.chromium.org/2215153002/diff/60001/chrome/test/chromedriver/chrome/frame_tracker.cc File chrome/test/chromedriver/chrome/frame_tracker.cc (right): https://codereview.chromium.org/2215153002/diff/60001/chrome/test/chromedriver/chrome/frame_tracker.cc#newcode74 chrome/test/chromedriver/chrome/frame_tracker.cc:74: On 2016/08/05 19:47:57, samuong wrote: > we should ...
4 years, 4 months ago (2016-08-05 21:11:16 UTC) #13
samuong
https://codereview.chromium.org/2215153002/diff/80001/chrome/test/chromedriver/chrome/navigation_tracker.cc File chrome/test/chromedriver/chrome/navigation_tracker.cc (right): https://codereview.chromium.org/2215153002/diff/80001/chrome/test/chromedriver/chrome/navigation_tracker.cc#newcode331 chrome/test/chromedriver/chrome/navigation_tracker.cc:331: std::string frame_id; need to declare and initialize |context| here?
4 years, 4 months ago (2016-08-05 21:23:59 UTC) #14
dgozman
PTAL https://codereview.chromium.org/2215153002/diff/80001/chrome/test/chromedriver/chrome/navigation_tracker.cc File chrome/test/chromedriver/chrome/navigation_tracker.cc (right): https://codereview.chromium.org/2215153002/diff/80001/chrome/test/chromedriver/chrome/navigation_tracker.cc#newcode331 chrome/test/chromedriver/chrome/navigation_tracker.cc:331: std::string frame_id; On 2016/08/05 21:23:59, samuong wrote: > ...
4 years, 4 months ago (2016-08-05 21:33:31 UTC) #15
samuong
no worries, lgtm
4 years, 4 months ago (2016-08-05 21:35:40 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2215153002/100001
4 years, 4 months ago (2016-08-05 23:48:29 UTC) #19
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 4 months ago (2016-08-06 01:03:15 UTC) #20
commit-bot: I haz the power
4 years, 4 months ago (2016-08-06 01:04:57 UTC) #22
Message was sent while issue was closed. 
Patchset 6 (id:??) landed as
https://crrev.com/be29687013b17e0a1280414e4152f567091ab3bc
Cr-Commit-Position: refs/heads/master@{#410239}

Powered by Google App Engine
This is Rietveld 408576698