third_party/WebKit/Source/platform/v8_inspector/InspectedContext.h - Issue 2215153002: [DevTools] Eliminate frameId and isContentScript from js protocol.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/InspectedContext.h

Issue 2215153002: [DevTools] Eliminate frameId and isContentScript from js protocol. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: navigation tracker Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/DebuggerScript.js ('k') | third_party/WebKit/Source/platform/v8_inspector/InspectedContext.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/InspectedContext.h

diff --git a/third_party/WebKit/Source/platform/v8_inspector/InspectedContext.h b/third_party/WebKit/Source/platform/v8_inspector/InspectedContext.h

index aadb810c7a945596f089c0b0bccc26ea5de49e65..421d3dfe03a4190d52344277a512ebe8b90fffa1 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/InspectedContext.h

+++ b/third_party/WebKit/Source/platform/v8_inspector/InspectedContext.h

@@ -25,10 +25,9 @@ public:

v8::Local<v8::Context> context() const;

int contextId() const { return m_contextId; }

int contextGroupId() const { return m_contextGroupId; }

- bool isDefault() const { return m_isDefault; }

String16 origin() const { return m_origin; }

String16 humanReadableName() const { return m_humanReadableName; }

- String16 frameId() const { return m_frameId; }

+ String16 auxData() const { return m_auxData; }

bool isReported() const { return m_reported; }

void setReported(bool reported) { m_reported = reported; }

@@ -50,10 +49,9 @@ private:

v8::Global<v8::Context> m_context;

int m_contextId;

int m_contextGroupId;

- bool m_isDefault;

const String16 m_origin;

const String16 m_humanReadableName;

- const String16 m_frameId;

+ const String16 m_auxData;

bool m_reported;

std::unique_ptr<InjectedScript> m_injectedScript;

v8::Global<v8::Object> m_console;