Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(695)

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/public/V8ContextInfo.h

Issue 2215153002: [DevTools] Eliminate frameId and isContentScript from js protocol. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: navigation tracker Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/public/SimpleInspector.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/platform/v8_inspector/public/V8ContextInfo.h
diff --git a/third_party/WebKit/Source/platform/v8_inspector/public/V8ContextInfo.h b/third_party/WebKit/Source/platform/v8_inspector/public/V8ContextInfo.h
index 0dc1de29da75e533bf1b5357a2eb9645218b2805..81a98e6c5201985c93e5367e2402c9cf13f470b6 100644
--- a/third_party/WebKit/Source/platform/v8_inspector/public/V8ContextInfo.h
+++ b/third_party/WebKit/Source/platform/v8_inspector/public/V8ContextInfo.h
@@ -13,14 +13,11 @@ namespace blink {
class V8ContextInfo {
public:
- V8ContextInfo(v8::Local<v8::Context> context, int contextGroupId, bool isDefault, const String16& origin, const String16& humanReadableName, const String16& frameId, bool hasMemoryOnConsole)
+ V8ContextInfo(v8::Local<v8::Context> context, int contextGroupId, const String16& humanReadableName)
: context(context)
, contextGroupId(contextGroupId)
- , isDefault(isDefault)
- , origin(origin)
, humanReadableName(humanReadableName)
- , frameId(frameId)
- , hasMemoryOnConsole(hasMemoryOnConsole)
+ , hasMemoryOnConsole(false)
{
}
@@ -29,11 +26,9 @@ public:
// V8DebuggerAgent to notify about events in the context.
// |contextGroupId| must be non-0.
int contextGroupId;
- bool isDefault;
- const String16 origin;
- const String16 humanReadableName;
- // TODO(dgozman): aux data?
- const String16 frameId;
+ String16 humanReadableName;
+ String16 origin;
+ String16 auxData;
bool hasMemoryOnConsole;
};
« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/public/SimpleInspector.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698