third_party/WebKit/Source/platform/inspector_protocol/generate-inspector-protocol-version - Issue 2215153002: [DevTools] Eliminate frameId and isContentScript from js protocol.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/inspector_protocol/generate-inspector-protocol-version

Issue 2215153002: [DevTools] Eliminate frameId and isContentScript from js protocol. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: navigation tracker Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js ('k') | third_party/WebKit/Source/platform/v8_inspector/DebuggerScript.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/inspector_protocol/generate-inspector-protocol-version

diff --git a/third_party/WebKit/Source/platform/inspector_protocol/generate-inspector-protocol-version b/third_party/WebKit/Source/platform/inspector_protocol/generate-inspector-protocol-version

index 838a3ed2dd815af85baccd59f203d17552c8cccb..d15f7658adc08845a9b876e9c801c4f15c59ecf7 100755

--- a/third_party/WebKit/Source/platform/inspector_protocol/generate-inspector-protocol-version

+++ b/third_party/WebKit/Source/platform/inspector_protocol/generate-inspector-protocol-version

@@ -451,7 +451,8 @@ def main():

load_domains_and_baselines(arg_values[1], domains, baseline_domains)

expected_errors = [

- "Debugger.globalObjectCleared: event has been removed"

+ "Debugger.globalObjectCleared: event has been removed",

+ "Runtime.executionContextCreated.context parameter->Runtime.ExecutionContextDescription.frameId: required property has been removed"

]

errors = compare_schemas(baseline_domains, domains, False)