third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp - Issue 2215153002: [DevTools] Eliminate frameId and isContentScript from js protocol.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp

Issue 2215153002: [DevTools] Eliminate frameId and isContentScript from js protocol. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: navigation tracker Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/V8DebuggerScript.cpp ('k') | third_party/WebKit/Source/platform/v8_inspector/debugger_script_externs.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp

diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp b/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp

index 7c030806ee32509053e421a6effa09af4250e378..cf2c2ba82e78c37f908e18bc1283ad9a97fd7e2d 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp

+++ b/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp

@@ -30,6 +30,7 @@

#include "platform/v8_inspector/V8RuntimeAgentImpl.h"

+#include "platform/inspector_protocol/Parser.h"

#include "platform/inspector_protocol/Values.h"

#include "platform/v8_inspector/InjectedScript.h"

#include "platform/v8_inspector/InspectedContext.h"

@@ -649,10 +650,10 @@ void V8RuntimeAgentImpl::reportExecutionContextCreated(InspectedContext* context

context->setReported(true);

std::unique_ptr<protocol::Runtime::ExecutionContextDescription> description = protocol::Runtime::ExecutionContextDescription::create()

.setId(context->contextId())

- .setIsDefault(context->isDefault())

.setName(context->humanReadableName())

- .setOrigin(context->origin())

- .setFrameId(context->frameId()).build();

+ .setOrigin(context->origin()).build();

+ if (!context->auxData().isEmpty())

+ description->setAuxData(protocol::DictionaryValue::cast(parseJSON(context->auxData())));

m_frontend.executionContextCreated(std::move(description));

}