third_party/WebKit/Source/platform/v8_inspector/public/SimpleInspector.cpp - Issue 2215153002: [DevTools] Eliminate frameId and isContentScript from js protocol.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/public/SimpleInspector.cpp

Issue 2215153002: [DevTools] Eliminate frameId and isContentScript from js protocol. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: navigation tracker Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/js_protocol.json ('k') | third_party/WebKit/Source/platform/v8_inspector/public/V8ContextInfo.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/public/SimpleInspector.cpp

diff --git a/third_party/WebKit/Source/platform/v8_inspector/public/SimpleInspector.cpp b/third_party/WebKit/Source/platform/v8_inspector/public/SimpleInspector.cpp

index e6cb62eb99e63998314c595aa7e36bf07d4cded7..ebd9fe708937c90a6d7bc7e5e06df67e34fda412 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/public/SimpleInspector.cpp

+++ b/third_party/WebKit/Source/platform/v8_inspector/public/SimpleInspector.cpp

@@ -16,8 +16,7 @@ SimpleInspector::SimpleInspector(v8::Isolate* isolate, v8::Local<v8::Context> co

: m_context(context)

{

m_inspector = V8Inspector::create(isolate, this);

- m_inspector->contextCreated(V8ContextInfo(context, 1, true, "",

- "NodeJS Main Context", "", false));

+ m_inspector->contextCreated(V8ContextInfo(context, 1, "NodeJS Main Context"));

}

SimpleInspector::~SimpleInspector()