third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/last-execution-context.html - Issue 2215153002: [DevTools] Eliminate frameId and isContentScript from js protocol.

Unified Diff: third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/last-execution-context.html

Issue 2215153002: [DevTools] Eliminate frameId and isContentScript from js protocol. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: navigation tracker Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/chromedriver/chrome/navigation_tracker.cc ('k') | third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/last-execution-context.html

diff --git a/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/last-execution-context.html b/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/last-execution-context.html

index 939f4705e538bba752740db31c791835c0fef7fd..655319c7ab5df53623d9c9a279931137827839ba 100644

--- a/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/last-execution-context.html

+++ b/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/last-execution-context.html

@@ -27,14 +27,14 @@ function test()

InspectorTest.addResult("");

InspectorTest.addResult("Adding page target");

var pageTarget = InspectorTest.createMockTarget("page-target");

- pageTarget.runtimeModel._executionContextCreated({id: "cs1", isDefault: false, origin: "origin", name: "contentScript1", frameId: "42"});

- pageTarget.runtimeModel._executionContextCreated({id: "if1", isDefault: true, origin: "origin", name: "iframeContext1", frameId: "iframe1"});

- pageTarget.runtimeModel._executionContextCreated({id: "p1", isDefault: true, origin: "origin", name: "pageContext1Name", frameId: "42"});

+ pageTarget.runtimeModel._executionContextCreated({id: "cs1", auxData: { isDefault: false, frameId: "42" }, origin: "origin", name: "contentScript1"});

+ pageTarget.runtimeModel._executionContextCreated({id: "if1", auxData: { isDefault: true, frameId: "iframe1" }, origin: "origin", name: "iframeContext1"});

+ pageTarget.runtimeModel._executionContextCreated({id: "p1", auxData: { isDefault: true, frameId: "42" }, origin: "origin", name: "pageContext1Name"});

InspectorTest.addResult("");

InspectorTest.addResult("Adding sw target");

var swTarget = InspectorTest.createMockTarget("sw-target", null, WebInspector.Target.Capability.Network | WebInspector.Target.Capability.Worker);

- swTarget.runtimeModel._executionContextCreated({id: "sw1", isDefault: true, origin: "origin", name: "swContext1Name", frameId: ""});

+ swTarget.runtimeModel._executionContextCreated({id: "sw1", auxData: { isDefault: true, frameId: "" }, origin: "origin", name: "swContext1Name"});

InspectorTest.addResult("");

InspectorTest.addResult("Removing page main frame");

@@ -42,7 +42,7 @@ function test()

InspectorTest.addResult("");

InspectorTest.addResult("Readding page main frame");

- pageTarget.runtimeModel._executionContextCreated({id: "p2", isDefault: true, origin: "origin", name: "pageContext1Name", frameId: "42"});

+ pageTarget.runtimeModel._executionContextCreated({id: "p2", auxData: { isDefault: true, frameId: "42" }, origin: "origin", name: "pageContext1Name"});

InspectorTest.addResult("");

InspectorTest.addResult("Switching to sw target");

@@ -86,7 +86,7 @@ function test()

InspectorTest.addResult("");

InspectorTest.addResult("Readding page main frame");

- pageTarget.runtimeModel._executionContextCreated({id: "p3", isDefault: true, origin: "origin", name: "pageContext1Name", frameId: "42"});

+ pageTarget.runtimeModel._executionContextCreated({id: "p3", auxData: { isDefault: true, frameId: "42" }, origin: "origin", name: "pageContext1Name"});

InspectorTest.completeTest();

}