Revert of GrFP can express distance vector field req., program builder declares variable for it

Revert of GrFP can express distance vector field req.,  program builder declares variable for it (patchset #20 id:370001 of https://codereview.chromium.org/2114993002/ )

Reason for revert:
UBSAN says we're reading a bad bool here:
bool usesDistanceVectorField() const { return fUsesDistanceVectorField; }

../../../include/gpu/GrPaint.h:83:51: runtime error: load of value 239, which is not a valid value for type 'bool'
SUMMARY: AddressSanitizer: undefined-behavior ../../../include/gpu/GrPaint.h:83:51 in 


Seems likely also the root of Valgrind failure:
https://luci-milo.appspot.com/swarming/task/30522e4f2241cb10

Original issue's description:
> GrFP can express distance vector field req.,  program builder declares variable for it
> 
> This update allows fragment processors to require a field of vectors to the nearest edge. This requirement propagates:
> 
> - from child FPs to their parent
> - from parent FPs to the GrPaint
> - from GrPaint through the PipelineBuilder into GrPipeline
> - acessed from GrPipeline by GrGLSLProgramBuilder
> 
> GrGLSL generates a variable for the distance vector and passes it down to the GeometryProcessor->emitCode() method.
> 
> This CL's base is the CL for adding the BevelNormalSource API: https://codereview.chromium.org/2080993002
> 
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2114993002
> 
> Committed: https://skia.googlesource.com/skia/+/4ef6dfa7089c092c67b0d5ec34e89c1e319af196

TBR=egdaniel@google.com,robertphillips@google.com,bsalomon@google.com,dvonbeck@google.com
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=skia:

Committed: https://skia.googlesource.com/skia/+/02aed95f9c7c6745c02e9aa8604d27d7a3ae93db

[mtklein, 2016-07-30 19:41:18]

The CQ bit was checked by mtklein@google.com

[mtklein, 2016-07-30 19:41:19]

Created Revert of GrFP can express distance vector field req.,  program builder
declares variable for it

[commit-bot: I haz the power, 2016-07-30 19:41:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-30 19:44:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-30 19:44:35]

Try jobs failed on following builders:
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on
master.client.skia (JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)
  Build-Ubuntu-Clang-x86_64-Debug-Trybot on master.client.skia.compile
(JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x...)

[mtklein, 2016-07-30 20:34:35]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2016-07-30 20:34:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-30 21:21:12]

Description was changed from

==========
Revert of GrFP can express distance vector field req.,  program builder declares
variable for it (patchset #20 id:370001 of
https://codereview.chromium.org/2114993002/ )

Reason for revert:
UBSAN says we're reading a bad bool here:
bool usesDistanceVectorField() const { return fUsesDistanceVectorField; }

../../../include/gpu/GrPaint.h:83:51: runtime error: load of value 239, which is
not a valid value for type 'bool'
SUMMARY: AddressSanitizer: undefined-behavior
../../../include/gpu/GrPaint.h:83:51 in 


Seems likely also the root of Valgrind failure:
https://luci-milo.appspot.com/swarming/task/30522e4f2241cb10

Original issue's description:
> GrFP can express distance vector field req.,  program builder declares
variable for it
> 
> This update allows fragment processors to require a field of vectors to the
nearest edge. This requirement propagates:
> 
> - from child FPs to their parent
> - from parent FPs to the GrPaint
> - from GrPaint through the PipelineBuilder into GrPipeline
> - acessed from GrPipeline by GrGLSLProgramBuilder
> 
> GrGLSL generates a variable for the distance vector and passes it down to the
GeometryProcessor->emitCode() method.
> 
> This CL's base is the CL for adding the BevelNormalSource API:
https://codereview.chromium.org/2080993002
> 
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2114993002
> 
> Committed:
https://skia.googlesource.com/skia/+/4ef6dfa7089c092c67b0d5ec34e89c1e319af196

TBR=egdaniel@google.com,robertphillips@google.com,bsalomon@google.com,dvonbec...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=skia:
==========

to

==========
Revert of GrFP can express distance vector field req.,  program builder declares
variable for it (patchset #20 id:370001 of
https://codereview.chromium.org/2114993002/ )

Reason for revert:
UBSAN says we're reading a bad bool here:
bool usesDistanceVectorField() const { return fUsesDistanceVectorField; }

../../../include/gpu/GrPaint.h:83:51: runtime error: load of value 239, which is
not a valid value for type 'bool'
SUMMARY: AddressSanitizer: undefined-behavior
../../../include/gpu/GrPaint.h:83:51 in 


Seems likely also the root of Valgrind failure:
https://luci-milo.appspot.com/swarming/task/30522e4f2241cb10

Original issue's description:
> GrFP can express distance vector field req.,  program builder declares
variable for it
> 
> This update allows fragment processors to require a field of vectors to the
nearest edge. This requirement propagates:
> 
> - from child FPs to their parent
> - from parent FPs to the GrPaint
> - from GrPaint through the PipelineBuilder into GrPipeline
> - acessed from GrPipeline by GrGLSLProgramBuilder
> 
> GrGLSL generates a variable for the distance vector and passes it down to the
GeometryProcessor->emitCode() method.
> 
> This CL's base is the CL for adding the BevelNormalSource API:
https://codereview.chromium.org/2080993002
> 
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2114993002
> 
> Committed:
https://skia.googlesource.com/skia/+/4ef6dfa7089c092c67b0d5ec34e89c1e319af196

TBR=egdaniel@google.com,robertphillips@google.com,bsalomon@google.com,dvonbec...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=skia:

Committed:
https://skia.googlesource.com/skia/+/02aed95f9c7c6745c02e9aa8604d27d7a3ae93db
==========

[commit-bot: I haz the power, 2016-07-30 21:21:13]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/02aed95f9c7c6745c02e9aa8604d27d7a3ae93db