Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Issue 2200273002: [DevTools] Cleanup mute exceptions, usecounter and deprecations in v8_inspector API. (Closed)

Created:
4 years, 4 months ago by dgozman
Modified:
4 years, 4 months ago
Reviewers:
kozy
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2205913002
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Cleanup mute exceptions, usecounter and deprecations in v8_inspector API. We now mute exceptions in v8 inspector, and mute deprecations/usecounter in core. BUG=631162 Committed: https://crrev.com/3dd254d2130c3a913b89cc37e51b56bdd68f094d Cr-Commit-Position: refs/heads/master@{#409430}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -55 lines) Patch
M third_party/WebKit/LayoutTests/inspector/console/command-line-api-getEventListeners-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameConsole.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/ConsoleMessageStorage.h View 1 chunk +1 line, -5 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/ConsoleMessageStorage.cpp View 4 chunks +1 line, -20 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/MainThreadDebugger.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp View 2 chunks +2 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.cpp View 2 chunks +2 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8FunctionCall.cpp View 1 chunk +8 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8InspectorImpl.h View 2 chunks +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8InspectorImpl.cpp View 3 chunks +12 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/public/V8InspectorClient.h View 1 chunk +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (5 generated)
dgozman
Take a look please.
4 years, 4 months ago (2016-08-02 20:47:15 UTC) #3
kozy
lgtm
4 years, 4 months ago (2016-08-02 20:55:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2200273002/1
4 years, 4 months ago (2016-08-03 00:54:07 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-03 02:08:36 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-08-03 02:10:34 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3dd254d2130c3a913b89cc37e51b56bdd68f094d
Cr-Commit-Position: refs/heads/master@{#409430}

Powered by Google App Engine
This is Rietveld 408576698