Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8FunctionCall.cpp

Issue 2200273002: [DevTools] Cleanup mute exceptions, usecounter and deprecations in v8_inspector API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2205913002
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/v8_inspector/V8FunctionCall.cpp
diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8FunctionCall.cpp b/third_party/WebKit/Source/platform/v8_inspector/V8FunctionCall.cpp
index c43eb462d9da6775a140680f738fdaf531c93a72..c58531408381c52d5f7426a331f8026606f8caf5 100644
--- a/third_party/WebKit/Source/platform/v8_inspector/V8FunctionCall.cpp
+++ b/third_party/WebKit/Source/platform/v8_inspector/V8FunctionCall.cpp
@@ -100,12 +100,16 @@ v8::Local<v8::Value> V8FunctionCall::callWithoutExceptionHandling()
}
int contextGroupId = V8Debugger::getGroupId(m_context);
- if (contextGroupId)
- m_inspector->client()->muteWarningsAndDeprecations(contextGroupId);
+ if (contextGroupId) {
+ m_inspector->client()->muteMetrics(contextGroupId);
+ m_inspector->muteExceptions(contextGroupId);
+ }
v8::MicrotasksScope microtasksScope(m_context->GetIsolate(), v8::MicrotasksScope::kDoNotRunMicrotasks);
v8::MaybeLocal<v8::Value> maybeResult = function->Call(m_context, thisObject, m_arguments.size(), info.get());
- if (contextGroupId)
- m_inspector->client()->unmuteWarningsAndDeprecations(contextGroupId);
+ if (contextGroupId) {
+ m_inspector->client()->unmuteMetrics(contextGroupId);
+ m_inspector->unmuteExceptions(contextGroupId);
+ }
v8::Local<v8::Value> result;
if (!maybeResult.ToLocal(&result))

Powered by Google App Engine
This is Rietveld 408576698