Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1540)

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8InspectorImpl.cpp

Issue 2200273002: [DevTools] Cleanup mute exceptions, usecounter and deprecations in v8_inspector API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2205913002
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/v8_inspector/V8InspectorImpl.cpp
diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8InspectorImpl.cpp b/third_party/WebKit/Source/platform/v8_inspector/V8InspectorImpl.cpp
index 33f32bad895737f53b50fef6b4c70d7c48b439e8..bca272a62dcb367594bb489fd17b278488c5effc 100644
--- a/third_party/WebKit/Source/platform/v8_inspector/V8InspectorImpl.cpp
+++ b/third_party/WebKit/Source/platform/v8_inspector/V8InspectorImpl.cpp
@@ -151,6 +151,16 @@ void V8InspectorImpl::disableStackCapturingIfNeeded()
V8StackTraceImpl::setCaptureStackTraceForUncaughtExceptions(m_isolate, false);
}
+void V8InspectorImpl::muteExceptions(int contextGroupId)
+{
+ m_muteExceptionsMap[contextGroupId]++;
+}
+
+void V8InspectorImpl::unmuteExceptions(int contextGroupId)
+{
+ m_muteExceptionsMap[contextGroupId]--;
+}
+
V8ConsoleMessageStorage* V8InspectorImpl::ensureConsoleMessageStorage(int contextGroupId)
{
ConsoleStorageMap::iterator storageIt = m_consoleStorageMap.find(contextGroupId);
@@ -231,6 +241,7 @@ void V8InspectorImpl::contextDestroyed(v8::Local<v8::Context> context)
void V8InspectorImpl::resetContextGroup(int contextGroupId)
{
m_consoleStorageMap.erase(contextGroupId);
+ m_muteExceptionsMap.erase(contextGroupId);
SessionMap::iterator session = m_sessions.find(contextGroupId);
if (session != m_sessions.end())
session->second->reset();
@@ -262,7 +273,7 @@ void V8InspectorImpl::idleFinished()
unsigned V8InspectorImpl::exceptionThrown(v8::Local<v8::Context> context, const String16& message, v8::Local<v8::Value> exception, const String16& detailedMessage, const String16& url, unsigned lineNumber, unsigned columnNumber, std::unique_ptr<V8StackTrace> stackTrace, int scriptId)
{
int contextGroupId = V8Debugger::getGroupId(context);
- if (!contextGroupId)
+ if (!contextGroupId || m_muteExceptionsMap[contextGroupId])
return 0;
std::unique_ptr<V8StackTraceImpl> stackTraceImpl = wrapUnique(static_cast<V8StackTraceImpl*>(stackTrace.release()));
unsigned exceptionId = ++m_lastExceptionId;

Powered by Google App Engine
This is Rietveld 408576698