third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp - Issue 2200273002: [DevTools] Cleanup mute exceptions, usecounter and deprecations in v8_inspector API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp

Issue 2200273002: [DevTools] Cleanup mute exceptions, usecounter and deprecations in v8_inspector API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2205913002

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.cpp ('k') | third_party/WebKit/Source/platform/v8_inspector/V8FunctionCall.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp

diff --git a/third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp b/third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp

index d3fcecf9f84c33de188e761d681feb29b52002b1..7a4ad6bb377db5038529b3ba5e8060abf12960e8 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp

+++ b/third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp

@@ -393,7 +393,8 @@ void InjectedScript::Scope::ignoreExceptionsAndMuteConsole()

{

DCHECK(!m_ignoreExceptionsAndMuteConsole);

m_ignoreExceptionsAndMuteConsole = true;

- m_inspector->client()->muteWarningsAndDeprecations(m_contextGroupId);

+ m_inspector->client()->muteMetrics(m_contextGroupId);

+ m_inspector->muteExceptions(m_contextGroupId);

m_previousPauseOnExceptionsState = setPauseOnExceptionsState(V8Debugger::DontPauseOnExceptions);

}

@@ -427,7 +428,8 @@ InjectedScript::Scope::~Scope()

{

if (m_ignoreExceptionsAndMuteConsole) {

setPauseOnExceptionsState(m_previousPauseOnExceptionsState);

- m_inspector->client()->unmuteWarningsAndDeprecations(m_contextGroupId);

+ m_inspector->client()->unmuteMetrics(m_contextGroupId);

+ m_inspector->unmuteExceptions(m_contextGroupId);

}

if (m_userGesture)

m_inspector->client()->endUserGesture();