Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 2205913002: [DevTools] Split a part of V8Inspector into V8Debugger. (Closed)

Created:
4 years, 4 months ago by dgozman
Modified:
4 years, 4 months ago
Reviewers:
kozy, pfeldman
CC:
chromium-reviews, Dirk Pranke, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@v8-inspector-rename
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Split a part of V8Inspector into V8Debugger. BUG=none TBR=pfeldman Committed: https://crrev.com/c38cfc5ebfb31645597e61aa428b82214aa201c1 Cr-Commit-Position: refs/heads/master@{#409293}

Patch Set 1 #

Patch Set 2 : minor fixes #

Total comments: 1

Patch Set 3 : context scope! #

Unified diffs Side-by-side diffs Delta from patch set Stats (+400 lines, -1435 lines) Patch
M third_party/WebKit/Source/platform/blink_platform.gypi View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/InjectedScript.h View 3 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp View 3 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8Console.cpp View 1 2 2 chunks +2 lines, -1 line 0 comments Download
A third_party/WebKit/Source/platform/v8_inspector/V8Debugger.h View 1 chunk +127 lines, -0 lines 0 comments Download
A + third_party/WebKit/Source/platform/v8_inspector/V8Debugger.cpp View 1 2 39 chunks +102 lines, -411 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.h View 2 chunks +6 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp View 29 chunks +52 lines, -49 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8FunctionCall.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8HeapProfilerAgentImpl.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8InspectorImpl.h View 1 5 chunks +17 lines, -103 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8InspectorImpl.cpp View 12 chunks +46 lines, -837 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.cpp View 3 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp View 4 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.h View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.cpp View 1 6 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8StringUtil.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8StringUtil.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/public/V8Inspector.h View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/public/V8InspectorClient.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/v8_inspector.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 18 (11 generated)
dgozman
Could you please take a look?
4 years, 4 months ago (2016-08-02 16:45:34 UTC) #2
kozy
lgtm https://codereview.chromium.org/2205913002/diff/20001/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.h File third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.h (right): https://codereview.chromium.org/2205913002/diff/20001/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.h#newcode18 third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.h:18: class JavaScriptCallFrame; It's redundant.
4 years, 4 months ago (2016-08-02 17:26:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2205913002/20001
4 years, 4 months ago (2016-08-02 17:53:47 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/270209)
4 years, 4 months ago (2016-08-02 18:00:15 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2205913002/40001
4 years, 4 months ago (2016-08-02 18:28:15 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-02 20:09:52 UTC) #16
commit-bot: I haz the power
4 years, 4 months ago (2016-08-02 20:11:17 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/c38cfc5ebfb31645597e61aa428b82214aa201c1
Cr-Commit-Position: refs/heads/master@{#409293}

Powered by Google App Engine
This is Rietveld 408576698