Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Unified Diff: third_party/WebKit/Source/core/inspector/ConsoleMessageStorage.cpp

Issue 2200273002: [DevTools] Cleanup mute exceptions, usecounter and deprecations in v8_inspector API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2205913002
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/ConsoleMessageStorage.cpp
diff --git a/third_party/WebKit/Source/core/inspector/ConsoleMessageStorage.cpp b/third_party/WebKit/Source/core/inspector/ConsoleMessageStorage.cpp
index 70ba51e1125066f7235ca186ce0853536ab44ed2..015ba2f201a658fd1dd179e62a949c2b08145ebe 100644
--- a/third_party/WebKit/Source/core/inspector/ConsoleMessageStorage.cpp
+++ b/third_party/WebKit/Source/core/inspector/ConsoleMessageStorage.cpp
@@ -13,14 +13,11 @@ static const unsigned maxConsoleMessageCount = 1000;
ConsoleMessageStorage::ConsoleMessageStorage()
: m_expiredCount(0)
- , m_mutedCount(0)
{
}
-bool ConsoleMessageStorage::addConsoleMessage(ExecutionContext* context, ConsoleMessage* message)
+void ConsoleMessageStorage::addConsoleMessage(ExecutionContext* context, ConsoleMessage* message)
{
- if (m_mutedCount)
- return false;
InspectorInstrumentation::consoleMessageAdded(context, message);
DCHECK(m_messages.size() <= maxConsoleMessageCount);
if (m_messages.size() == maxConsoleMessageCount) {
@@ -28,7 +25,6 @@ bool ConsoleMessageStorage::addConsoleMessage(ExecutionContext* context, Console
m_messages.removeFirst();
}
m_messages.append(message);
- return true;
}
void ConsoleMessageStorage::clear()
@@ -37,16 +33,6 @@ void ConsoleMessageStorage::clear()
m_expiredCount = 0;
}
-void ConsoleMessageStorage::mute()
-{
- ++m_mutedCount;
-}
-
-void ConsoleMessageStorage::unmute()
-{
- --m_mutedCount;
-}
-
size_t ConsoleMessageStorage::size() const
{
return m_messages.size();
@@ -62,11 +48,6 @@ int ConsoleMessageStorage::expiredCount() const
return m_expiredCount;
}
-bool ConsoleMessageStorage::isMuted() const
-{
- return m_mutedCount;
-}
-
DEFINE_TRACE(ConsoleMessageStorage)
{
visitor->trace(m_messages);

Powered by Google App Engine
This is Rietveld 408576698