Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Unified Diff: third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp

Issue 2200273002: [DevTools] Cleanup mute exceptions, usecounter and deprecations in v8_inspector API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2205913002
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp
diff --git a/third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp b/third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp
index e9ea181b98fd5e72e368e8bef4e2b97b9a9b9635..52e1e8f0ab92389c612d5a89f47b15427e79cf72 100644
--- a/third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp
+++ b/third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp
@@ -167,9 +167,6 @@ void MainThreadDebugger::exceptionThrown(ExecutionContext* context, ErrorEvent*
scriptState = toMainThreadWorkletGlobalScope(context)->scriptController()->getScriptState();
}
- if (frame->host() && frame->host()->consoleMessageStorage().isMuted())
- return;
-
const String16 defaultMessage = "Uncaught";
if (scriptState && scriptState->contextIsValid()) {
ScriptState::Scope scope(scriptState);
@@ -228,21 +225,19 @@ void MainThreadDebugger::quitMessageLoopOnPause()
m_clientMessageLoop->quitNow();
}
-void MainThreadDebugger::muteWarningsAndDeprecations(int contextGroupId)
+void MainThreadDebugger::muteMetrics(int contextGroupId)
{
LocalFrame* frame = WeakIdentifierMap<LocalFrame>::lookup(contextGroupId);
if (frame && frame->host()) {
- frame->host()->consoleMessageStorage().mute();
frame->host()->useCounter().muteForInspector();
frame->host()->deprecation().muteForInspector();
}
}
-void MainThreadDebugger::unmuteWarningsAndDeprecations(int contextGroupId)
+void MainThreadDebugger::unmuteMetrics(int contextGroupId)
{
LocalFrame* frame = WeakIdentifierMap<LocalFrame>::lookup(contextGroupId);
if (frame && frame->host()) {
- frame->host()->consoleMessageStorage().unmute();
frame->host()->useCounter().unmuteForInspector();
frame->host()->deprecation().unmuteForInspector();
}

Powered by Google App Engine
This is Rietveld 408576698