content/browser/push_messaging/push_messaging_router.cc - Issue 2183783002: Revert of Stop passing const-reference of SWRegistration in all GetRegistrationsCallbacks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/push_messaging/push_messaging_router.cc

Issue 2183783002: Revert of Stop passing const-reference of SWRegistration in all GetRegistrationsCallbacks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/push_messaging/push_messaging_router.h ('k') | content/browser/service_worker/foreign_fetch_request_handler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/push_messaging/push_messaging_router.cc

diff --git a/content/browser/push_messaging/push_messaging_router.cc b/content/browser/push_messaging/push_messaging_router.cc

index 01a85749c83967c436cf1fa6f557f836cd2981e5..8e93fe71ece00d45b30c3f57a4b548f44b5dbb5b 100644

--- a/content/browser/push_messaging/push_messaging_router.cc

+++ b/content/browser/push_messaging/push_messaging_router.cc

@@ -73,7 +73,8 @@

const PushEventPayload& payload,

const DeliverMessageCallback& deliver_message_callback,

ServiceWorkerStatusCode service_worker_status,

- scoped_refptr<ServiceWorkerRegistration> service_worker_registration) {

+ const scoped_refptr<ServiceWorkerRegistration>&

+ service_worker_registration) {

DCHECK_CURRENTLY_ON(BrowserThread::IO);

// TODO(mvanouwerkerk): UMA logging.

if (service_worker_status != SERVICE_WORKER_OK) {