content/browser/service_worker/service_worker_register_job.h - Issue 2183783002: Revert of Stop passing const-reference of SWRegistration in all GetRegistrationsCallbacks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_register_job.h

Issue 2183783002: Revert of Stop passing const-reference of SWRegistration in all GetRegistrationsCallbacks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_read_from_cache_job_unittest.cc ('k') | content/browser/service_worker/service_worker_register_job.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_register_job.h

diff --git a/content/browser/service_worker/service_worker_register_job.h b/content/browser/service_worker/service_worker_register_job.h

index 7ec65a8bab223f24e2c3387717eb9b0865176f1c..153203eab46d0617a6bc14a1cd71388567405758 100644

--- a/content/browser/service_worker/service_worker_register_job.h

+++ b/content/browser/service_worker/service_worker_register_job.h

@@ -96,7 +96,8 @@

scoped_refptr<ServiceWorkerVersion> new_version;

};

- void set_registration(scoped_refptr<ServiceWorkerRegistration> registration);

+ void set_registration(

+ const scoped_refptr<ServiceWorkerRegistration>& registration);

ServiceWorkerRegistration* registration();

void set_new_version(ServiceWorkerVersion* version);

ServiceWorkerVersion* new_version();

@@ -106,16 +107,16 @@

void StartImpl();

void ContinueWithRegistration(

ServiceWorkerStatusCode status,

- scoped_refptr<ServiceWorkerRegistration> registration);

+ const scoped_refptr<ServiceWorkerRegistration>& registration);

void ContinueWithUpdate(

ServiceWorkerStatusCode status,

- scoped_refptr<ServiceWorkerRegistration> registration);

+ const scoped_refptr<ServiceWorkerRegistration>& registration);

void RegisterAndContinue();

void ContinueWithUninstallingRegistration(

- scoped_refptr<ServiceWorkerRegistration> existing_registration,

+ const scoped_refptr<ServiceWorkerRegistration>& existing_registration,

ServiceWorkerStatusCode status);

void ContinueWithRegistrationForSameScriptUrl(

- scoped_refptr<ServiceWorkerRegistration> existing_registration,

+ const scoped_refptr<ServiceWorkerRegistration>& existing_registration,

ServiceWorkerStatusCode status);

void UpdateAndContinue();

void OnStartWorkerFinished(ServiceWorkerStatusCode status);