Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1600)

Unified Diff: content/browser/service_worker/service_worker_context_core.cc

Issue 2183783002: Revert of Stop passing const-reference of SWRegistration in all GetRegistrationsCallbacks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_context_core.cc
diff --git a/content/browser/service_worker/service_worker_context_core.cc b/content/browser/service_worker/service_worker_context_core.cc
index eff6187fca5870490e291d4d26f80a2c74a1ec1e..2db3464318f900b4b407e646fcaf8c8ae9359e90 100644
--- a/content/browser/service_worker/service_worker_context_core.cc
+++ b/content/browser/service_worker/service_worker_context_core.cc
@@ -823,7 +823,7 @@
const GURL& other_url,
const ServiceWorkerContext::CheckHasServiceWorkerCallback callback,
ServiceWorkerStatusCode status,
- scoped_refptr<ServiceWorkerRegistration> registration) {
+ const scoped_refptr<ServiceWorkerRegistration>& registration) {
if (status != SERVICE_WORKER_OK) {
callback.Run(false);
return;
@@ -843,7 +843,7 @@
registration->RegisterRegistrationFinishedCallback(
base::Bind(&ServiceWorkerContextCore::
OnRegistrationFinishedForCheckHasServiceWorker,
- AsWeakPtr(), callback, std::move(registration)));
+ AsWeakPtr(), callback, registration));
return;
}
@@ -852,7 +852,7 @@
void ServiceWorkerContextCore::OnRegistrationFinishedForCheckHasServiceWorker(
const ServiceWorkerContext::CheckHasServiceWorkerCallback callback,
- scoped_refptr<ServiceWorkerRegistration> registration) {
+ const scoped_refptr<ServiceWorkerRegistration>& registration) {
callback.Run(registration->active_version() ||
registration->waiting_version());
}

Powered by Google App Engine
This is Rietveld 408576698