content/browser/service_worker/service_worker_browsertest.cc - Issue 2183783002: Revert of Stop passing const-reference of SWRegistration in all GetRegistrationsCallbacks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_browsertest.cc

Issue 2183783002: Revert of Stop passing const-reference of SWRegistration in all GetRegistrationsCallbacks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/foreign_fetch_request_handler.cc ('k') | content/browser/service_worker/service_worker_context_core.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_browsertest.cc

diff --git a/content/browser/service_worker/service_worker_browsertest.cc b/content/browser/service_worker/service_worker_browsertest.cc

index e10b3e27eec3c682997159d6ce47d1a6718a0f4f..0be509943dca192581a7849c33fbb8c24d698902 100644

--- a/content/browser/service_worker/service_worker_browsertest.cc

+++ b/content/browser/service_worker/service_worker_browsertest.cc

@@ -134,7 +134,7 @@

const base::Closure& quit,

ServiceWorkerStatusCode* out_status,

ServiceWorkerStatusCode status,

- scoped_refptr<ServiceWorkerRegistration> registration) {

+ const scoped_refptr<ServiceWorkerRegistration>& registration) {

*out_status = status;

if (!quit.is_null())

BrowserThread::PostTask(run_quit_thread, FROM_HERE, quit);

@@ -1426,7 +1426,7 @@

ServiceWorkerStatusCode* out_status,

const base::Closure& continuation,

ServiceWorkerStatusCode status,

- scoped_refptr<ServiceWorkerRegistration> registration) {

+ const scoped_refptr<ServiceWorkerRegistration>& registration) {

*out_status = status;

if (!registration.get())

EXPECT_NE(SERVICE_WORKER_OK, status);