content/browser/service_worker/service_worker_storage.h - Issue 2183783002: Revert of Stop passing const-reference of SWRegistration in all GetRegistrationsCallbacks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_storage.h

Issue 2183783002: Revert of Stop passing const-reference of SWRegistration in all GetRegistrationsCallbacks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_register_job.cc ('k') | content/browser/service_worker/service_worker_storage.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_storage.h

diff --git a/content/browser/service_worker/service_worker_storage.h b/content/browser/service_worker/service_worker_storage.h

index 1667b54a795eb915cb0a13f50bb4834082bda83c..61ce44dc35e39237b5673e84fed05cf11630caa7 100644

--- a/content/browser/service_worker/service_worker_storage.h

+++ b/content/browser/service_worker/service_worker_storage.h

@@ -57,10 +57,9 @@

public:

typedef std::vector<ServiceWorkerDatabase::ResourceRecord> ResourceList;

typedef base::Callback<void(ServiceWorkerStatusCode status)> StatusCallback;

- typedef base::Callback<void(

- ServiceWorkerStatusCode status,

- scoped_refptr<ServiceWorkerRegistration> registration)>

- FindRegistrationCallback;

+ typedef base::Callback<void(ServiceWorkerStatusCode status,

+ const scoped_refptr<ServiceWorkerRegistration>&

+ registration)> FindRegistrationCallback;

typedef base::Callback<void(

ServiceWorkerStatusCode status,

const std::vector<scoped_refptr<ServiceWorkerRegistration>>&