Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 2182643003: Remove shell::Connection* parameter to InterfaceFactory<T>::Create() (Closed)

Created:
4 years, 5 months ago by Ben Goodger (Google)
Modified:
4 years, 4 months ago
CC:
Aaron Boodman, abarth-chromium, alokp+watch_chromium.org, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, kalyank, mlamouri+watch-content_chromium.org, piman+watch_chromium.org, qsr+mojo_chromium.org, rjkroege, sadrul, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove shell::Connection* parameter to InterfaceFactory<T>::Create() Replace with shell::Identity, since that's all anyone used. R=rockot@chromium.org BUG= Committed: https://crrev.com/0b326f1b91f8f70f94ddb11e51c15beb6cb2e286 Cr-Commit-Position: refs/heads/master@{#407854}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Total comments: 1

Patch Set 5 : . #

Patch Set 6 : . #

Patch Set 7 : . #

Patch Set 8 : . #

Patch Set 9 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+192 lines, -187 lines) Patch
M ash/mus/window_manager_application.h View 1 chunk +3 lines, -3 lines 0 comments Download
M ash/mus/window_manager_application.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M ash/sysui/sysui_application.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/sysui/sysui_application.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/touch_hud/mus/touch_hud_application.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/touch_hud/mus/touch_hud_application.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/mash/mash_runner.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/filesystem/file_system_app.h View 1 chunk +1 line, -1 line 0 comments Download
M components/filesystem/file_system_app.cc View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M components/filesystem/file_system_impl.h View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M components/filesystem/file_system_impl.cc View 1 2 3 4 5 1 chunk +3 lines, -3 lines 0 comments Download
M components/font_service/font_service_app.h View 1 chunk +1 line, -1 line 0 comments Download
M components/font_service/font_service_app.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M components/leveldb/leveldb_app.h View 1 chunk +1 line, -1 line 0 comments Download
M components/leveldb/leveldb_app.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/mojo/mojo_shell_connection_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/public/test/test_mojo_app.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/test/test_mojo_app.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/mus/render_widget_window_tree_client_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/webui/mojo_facade_unittest.mm View 1 2 3 4 5 6 7 2 chunks +2 lines, -1 line 0 comments Download
M ios/web/webui/web_ui_mojo_inttest.mm View 1 2 3 4 5 6 7 8 2 chunks +2 lines, -1 line 0 comments Download
M mash/browser/browser.h View 1 chunk +1 line, -1 line 0 comments Download
M mash/browser/browser.cc View 1 chunk +1 line, -1 line 0 comments Download
M mash/catalog_viewer/catalog_viewer.h View 1 chunk +1 line, -1 line 0 comments Download
M mash/catalog_viewer/catalog_viewer.cc View 1 chunk +1 line, -1 line 0 comments Download
M mash/example/views_examples/views_examples_application_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M mash/example/views_examples/views_examples_application_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M mash/example/window_type_launcher/window_type_launcher.h View 1 chunk +1 line, -1 line 0 comments Download
M mash/example/window_type_launcher/window_type_launcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M mash/init/init.h View 1 chunk +1 line, -1 line 0 comments Download
M mash/init/init.cc View 1 chunk +2 lines, -1 line 0 comments Download
M mash/login/login.cc View 1 chunk +1 line, -1 line 0 comments Download
M mash/quick_launch/quick_launch_application.h View 1 chunk +1 line, -1 line 0 comments Download
M mash/quick_launch/quick_launch_application.cc View 1 chunk +1 line, -1 line 0 comments Download
M mash/session/session.h View 1 chunk +1 line, -1 line 0 comments Download
M mash/session/session.cc View 1 chunk +1 line, -1 line 0 comments Download
M mash/task_viewer/task_viewer.h View 1 chunk +1 line, -1 line 0 comments Download
M mash/task_viewer/task_viewer.cc View 1 chunk +1 line, -1 line 0 comments Download
M mash/webtest/webtest.h View 1 chunk +1 line, -1 line 0 comments Download
M mash/webtest/webtest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/mojo/services/mojo_media_application.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M media/mojo/services/mojo_media_application.cc View 1 2 chunks +5 lines, -4 lines 0 comments Download
M services/catalog/catalog.h View 1 chunk +3 lines, -3 lines 0 comments Download
M services/catalog/catalog.cc View 1 chunk +6 lines, -8 lines 0 comments Download
M services/navigation/navigation.h View 1 chunk +1 line, -1 line 0 comments Download
M services/navigation/navigation.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/shell/background/tests/test_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/shell/public/cpp/interface_binder.h View 2 chunks +2 lines, -2 lines 0 comments Download
M services/shell/public/cpp/interface_factory.h View 2 chunks +2 lines, -2 lines 0 comments Download
M services/shell/public/cpp/interface_factory_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M services/shell/public/cpp/interface_registry.h View 1 chunk +1 line, -0 lines 0 comments Download
M services/shell/public/cpp/lib/callback_binder.h View 2 chunks +4 lines, -4 lines 0 comments Download
M services/shell/public/cpp/lib/callback_binder.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/shell/public/cpp/lib/interface_factory_binder.h View 1 chunk +2 lines, -2 lines 0 comments Download
M services/shell/public/cpp/lib/interface_registry.cc View 1 2 3 4 2 chunks +7 lines, -1 line 0 comments Download
M services/shell/public/cpp/tests/interface_registry_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M services/shell/service_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/shell/tests/connect/connect_test_app.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M services/shell/tests/connect/connect_test_class_app.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M services/shell/tests/connect/connect_test_driver.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/shell/tests/connect/connect_test_exe.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/shell/tests/connect/connect_test_package.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M services/shell/tests/connect/connect_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/shell/tests/lifecycle/app_client.h View 1 chunk +2 lines, -1 line 0 comments Download
M services/shell/tests/lifecycle/app_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/shell/tests/lifecycle/package.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M services/shell/tests/lifecycle/parent.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/shell/tests/shell/driver.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/shell/tests/shell/shell_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/shell/tests/shutdown/shutdown_client_app.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/shell/tests/shutdown/shutdown_service_app.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/tracing/public/cpp/tracing_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M services/tracing/public/cpp/tracing_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/tracing/tracing_app.h View 1 chunk +2 lines, -2 lines 0 comments Download
M services/tracing/tracing_app.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M services/ui/gpu/gpu_service_impl.h View 1 chunk +1 line, -6 lines 0 comments Download
M services/ui/gpu/gpu_service_impl.cc View 1 chunk +1 line, -2 lines 0 comments Download
M services/ui/input_devices/input_device_server.h View 1 chunk +1 line, -1 line 0 comments Download
M services/ui/input_devices/input_device_server.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/ui/public/cpp/tests/window_server_test_base.h View 1 chunk +1 line, -1 line 0 comments Download
M services/ui/public/cpp/tests/window_server_test_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/ui/service.h View 2 chunks +15 lines, -15 lines 0 comments Download
M services/ui/service.cc View 5 chunks +37 lines, -37 lines 0 comments Download
M services/ui/ws/window_tree_client_unittest.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M services/user/user_shell_client.h View 1 chunk +2 lines, -2 lines 0 comments Download
M services/user/user_shell_client.cc View 3 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 44 (31 generated)
Ben Goodger (Google)
4 years, 5 months ago (2016-07-25 22:11:05 UTC) #3
Ken Rockot(use gerrit already)
the few compile errors look trivial to resolve, so lgtm % those and the other ...
4 years, 5 months ago (2016-07-26 00:14:46 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2182643003/80001
4 years, 5 months ago (2016-07-26 02:50:24 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/41244)
4 years, 5 months ago (2016-07-26 02:59:08 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2182643003/100001
4 years, 4 months ago (2016-07-26 13:56:50 UTC) #26
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/41471)
4 years, 4 months ago (2016-07-26 14:03:24 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2182643003/120001
4 years, 4 months ago (2016-07-26 14:17:33 UTC) #31
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/41482)
4 years, 4 months ago (2016-07-26 14:23:59 UTC) #33
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2182643003/140001
4 years, 4 months ago (2016-07-26 14:41:36 UTC) #36
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/41492)
4 years, 4 months ago (2016-07-26 14:48:18 UTC) #38
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2182643003/160001
4 years, 4 months ago (2016-07-26 16:57:16 UTC) #41
commit-bot: I haz the power
Committed patchset #9 (id:160001)
4 years, 4 months ago (2016-07-26 18:13:58 UTC) #42
commit-bot: I haz the power
4 years, 4 months ago (2016-07-26 18:15:36 UTC) #44
Message was sent while issue was closed.
Patchset 9 (id:??) landed as
https://crrev.com/0b326f1b91f8f70f94ddb11e51c15beb6cb2e286
Cr-Commit-Position: refs/heads/master@{#407854}

Powered by Google App Engine
This is Rietveld 408576698