Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(610)

Side by Side Diff: services/ui/ws/window_tree_client_unittest.cc

Issue 2182643003: Remove shell::Connection* parameter to InterfaceFactory<T>::Create() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « services/ui/service.cc ('k') | services/user/user_shell_client.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <stddef.h> 5 #include <stddef.h>
6 #include <stdint.h> 6 #include <stdint.h>
7 7
8 #include "base/bind.h" 8 #include "base/bind.h"
9 #include "base/macros.h" 9 #include "base/macros.h"
10 #include "base/message_loop/message_loop.h" 10 #include "base/message_loop/message_loop.h"
(...skipping 458 matching lines...) Expand 10 before | Expand all | Expand 10 after
469 DCHECK(!run_loop_); 469 DCHECK(!run_loop_);
470 run_loop_.reset(new base::RunLoop); 470 run_loop_.reset(new base::RunLoop);
471 run_loop_->Run(); 471 run_loop_->Run();
472 run_loop_.reset(); 472 run_loop_.reset();
473 } 473 }
474 return std::move(client_impl_); 474 return std::move(client_impl_);
475 } 475 }
476 476
477 private: 477 private:
478 // InterfaceFactory<WindowTreeClient>: 478 // InterfaceFactory<WindowTreeClient>:
479 void Create(Connection* connection, 479 void Create(const shell::Identity& remote_identity,
480 InterfaceRequest<WindowTreeClient> request) override { 480 InterfaceRequest<WindowTreeClient> request) override {
481 client_impl_.reset(new TestWindowTreeClient()); 481 client_impl_.reset(new TestWindowTreeClient());
482 client_impl_->Bind(std::move(request)); 482 client_impl_->Bind(std::move(request));
483 if (run_loop_.get()) 483 if (run_loop_.get())
484 run_loop_->Quit(); 484 run_loop_->Quit();
485 } 485 }
486 486
487 std::unique_ptr<TestWindowTreeClient> client_impl_; 487 std::unique_ptr<TestWindowTreeClient> client_impl_;
488 std::unique_ptr<base::RunLoop> run_loop_; 488 std::unique_ptr<base::RunLoop> run_loop_;
489 489
(...skipping 1552 matching lines...) Expand 10 before | Expand all | Expand 10 after
2042 2042
2043 // TODO(sky): make sure coverage of what was 2043 // TODO(sky): make sure coverage of what was
2044 // WindowManagerTest.SecondEmbedRoot_InitService and 2044 // WindowManagerTest.SecondEmbedRoot_InitService and
2045 // WindowManagerTest.MultipleEmbedRootsBeforeWTHReady gets added to window 2045 // WindowManagerTest.MultipleEmbedRootsBeforeWTHReady gets added to window
2046 // manager 2046 // manager
2047 // tests. 2047 // tests.
2048 2048
2049 } // namespace test 2049 } // namespace test
2050 } // namespace ws 2050 } // namespace ws
2051 } // namespace ui 2051 } // namespace ui
OLDNEW
« no previous file with comments | « services/ui/service.cc ('k') | services/user/user_shell_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698