Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Side by Side Diff: services/tracing/public/cpp/tracing_impl.h

Issue 2182643003: Remove shell::Connection* parameter to InterfaceFactory<T>::Create() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef SERVICES_TRACING_PUBLIC_CPP_TRACING_IMPL_H_ 5 #ifndef SERVICES_TRACING_PUBLIC_CPP_TRACING_IMPL_H_
6 #define SERVICES_TRACING_PUBLIC_CPP_TRACING_IMPL_H_ 6 #define SERVICES_TRACING_PUBLIC_CPP_TRACING_IMPL_H_
7 7
8 #include "base/macros.h" 8 #include "base/macros.h"
9 #include "services/shell/public/cpp/interface_factory.h" 9 #include "services/shell/public/cpp/interface_factory.h"
10 #include "services/tracing/public/cpp/trace_provider_impl.h" 10 #include "services/tracing/public/cpp/trace_provider_impl.h"
(...skipping 11 matching lines...) Expand all
22 class TracingImpl : public shell::InterfaceFactory<tracing::TraceProvider> { 22 class TracingImpl : public shell::InterfaceFactory<tracing::TraceProvider> {
23 public: 23 public:
24 TracingImpl(); 24 TracingImpl();
25 ~TracingImpl() override; 25 ~TracingImpl() override;
26 26
27 // Connect to the Tracing service & provide tracing data on demand. 27 // Connect to the Tracing service & provide tracing data on demand.
28 void Initialize(shell::Connector* connector, const std::string& url); 28 void Initialize(shell::Connector* connector, const std::string& url);
29 29
30 private: 30 private:
31 // InterfaceFactory<tracing::TraceProvider> implementation. 31 // InterfaceFactory<tracing::TraceProvider> implementation.
32 void Create(shell::Connection* connection, 32 void Create(const shell::Identity& remote_identity,
33 tracing::TraceProviderRequest request) override; 33 tracing::TraceProviderRequest request) override;
34 34
35 std::unique_ptr<shell::Connection> connection_; 35 std::unique_ptr<shell::Connection> connection_;
36 TraceProviderImpl provider_impl_; 36 TraceProviderImpl provider_impl_;
37 37
38 DISALLOW_COPY_AND_ASSIGN(TracingImpl); 38 DISALLOW_COPY_AND_ASSIGN(TracingImpl);
39 }; 39 };
40 40
41 } // namespace mojo 41 } // namespace mojo
42 42
43 #endif // SERVICES_TRACING_PUBLIC_CPP_TRACING_IMPL_H_ 43 #endif // SERVICES_TRACING_PUBLIC_CPP_TRACING_IMPL_H_
OLDNEW
« no previous file with comments | « services/shell/tests/shutdown/shutdown_service_app.cc ('k') | services/tracing/public/cpp/tracing_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698