Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Side by Side Diff: services/tracing/tracing_app.h

Issue 2182643003: Remove shell::Connection* parameter to InterfaceFactory<T>::Create() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « services/tracing/public/cpp/tracing_impl.cc ('k') | services/tracing/tracing_app.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef SERVICES_TRACING_TRACING_APP_H_ 5 #ifndef SERVICES_TRACING_TRACING_APP_H_
6 #define SERVICES_TRACING_TRACING_APP_H_ 6 #define SERVICES_TRACING_TRACING_APP_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <memory> 10 #include <memory>
(...skipping 20 matching lines...) Expand all
31 public: 31 public:
32 TracingApp(); 32 TracingApp();
33 ~TracingApp() override; 33 ~TracingApp() override;
34 34
35 private: 35 private:
36 // shell::Service implementation. 36 // shell::Service implementation.
37 bool OnConnect(shell::Connection* connection) override; 37 bool OnConnect(shell::Connection* connection) override;
38 bool OnStop() override; 38 bool OnStop() override;
39 39
40 // shell::InterfaceFactory<TraceCollector> implementation. 40 // shell::InterfaceFactory<TraceCollector> implementation.
41 void Create(shell::Connection* connection, 41 void Create(const shell::Identity& remote_identity,
42 mojo::InterfaceRequest<TraceCollector> request) override; 42 mojo::InterfaceRequest<TraceCollector> request) override;
43 43
44 // shell::InterfaceFactory<StartupPerformanceDataCollector> implementation. 44 // shell::InterfaceFactory<StartupPerformanceDataCollector> implementation.
45 void Create( 45 void Create(
46 shell::Connection* connection, 46 const shell::Identity& remote_identity,
47 mojo::InterfaceRequest<StartupPerformanceDataCollector> request) override; 47 mojo::InterfaceRequest<StartupPerformanceDataCollector> request) override;
48 48
49 // tracing::TraceCollector implementation. 49 // tracing::TraceCollector implementation.
50 void Start(mojo::ScopedDataPipeProducerHandle stream, 50 void Start(mojo::ScopedDataPipeProducerHandle stream,
51 const mojo::String& categories) override; 51 const mojo::String& categories) override;
52 void StopAndFlush() override; 52 void StopAndFlush() override;
53 53
54 // StartupPerformanceDataCollector implementation. 54 // StartupPerformanceDataCollector implementation.
55 void SetShellProcessCreationTime(int64_t time) override; 55 void SetShellProcessCreationTime(int64_t time) override;
56 void SetShellMainEntryPointTime(int64_t time) override; 56 void SetShellMainEntryPointTime(int64_t time) override;
(...skipping 16 matching lines...) Expand all
73 StartupPerformanceTimes startup_performance_times_; 73 StartupPerformanceTimes startup_performance_times_;
74 bool tracing_active_; 74 bool tracing_active_;
75 mojo::String tracing_categories_; 75 mojo::String tracing_categories_;
76 76
77 DISALLOW_COPY_AND_ASSIGN(TracingApp); 77 DISALLOW_COPY_AND_ASSIGN(TracingApp);
78 }; 78 };
79 79
80 } // namespace tracing 80 } // namespace tracing
81 81
82 #endif // SERVICES_TRACING_TRACING_APP_H_ 82 #endif // SERVICES_TRACING_TRACING_APP_H_
OLDNEW
« no previous file with comments | « services/tracing/public/cpp/tracing_impl.cc ('k') | services/tracing/tracing_app.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698