Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Side by Side Diff: media/mojo/services/mojo_media_application.h

Issue 2182643003: Remove shell::Connection* parameter to InterfaceFactory<T>::Create() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « mash/webtest/webtest.cc ('k') | media/mojo/services/mojo_media_application.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef MEDIA_MOJO_SERVICES_MOJO_MEDIA_APPLICATION_H_ 5 #ifndef MEDIA_MOJO_SERVICES_MOJO_MEDIA_APPLICATION_H_
6 #define MEDIA_MOJO_SERVICES_MOJO_MEDIA_APPLICATION_H_ 6 #define MEDIA_MOJO_SERVICES_MOJO_MEDIA_APPLICATION_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <memory> 10 #include <memory>
(...skipping 23 matching lines...) Expand all
34 34
35 private: 35 private:
36 // shell::Service implementation. 36 // shell::Service implementation.
37 void OnStart(shell::Connector* connector, 37 void OnStart(shell::Connector* connector,
38 const shell::Identity& identity, 38 const shell::Identity& identity,
39 uint32_t id) final; 39 uint32_t id) final;
40 bool OnConnect(shell::Connection* connection) final; 40 bool OnConnect(shell::Connection* connection) final;
41 bool OnStop() final; 41 bool OnStop() final;
42 42
43 // shell::InterfaceFactory<mojom::ServiceFactory> implementation. 43 // shell::InterfaceFactory<mojom::ServiceFactory> implementation.
44 void Create(shell::Connection* connection, 44 void Create(const shell::Identity& remote_identity,
45 mojo::InterfaceRequest<mojom::ServiceFactory> request) final; 45 mojo::InterfaceRequest<mojom::ServiceFactory> request) final;
46 46
47 // Note: Since each instance runs on a different thread, do not share a common 47 // Note: Since each instance runs on a different thread, do not share a common
48 // MojoMediaClient with other instances to avoid threading issues. Hence using 48 // MojoMediaClient with other instances to avoid threading issues. Hence using
49 // a unique_ptr here. 49 // a unique_ptr here.
50 std::unique_ptr<MojoMediaClient> mojo_media_client_; 50 std::unique_ptr<MojoMediaClient> mojo_media_client_;
51 51
52 shell::Connector* connector_; 52 shell::Connector* connector_;
53 shell::mojom::InterfaceProvider* remote_interface_provider_ = nullptr;
53 scoped_refptr<MediaLog> media_log_; 54 scoped_refptr<MediaLog> media_log_;
54 shell::ServiceContextRefFactory ref_factory_; 55 shell::ServiceContextRefFactory ref_factory_;
55 }; 56 };
56 57
57 } // namespace media 58 } // namespace media
58 59
59 #endif // MEDIA_MOJO_SERVICES_MOJO_MEDIA_APPLICATION_H_ 60 #endif // MEDIA_MOJO_SERVICES_MOJO_MEDIA_APPLICATION_H_
OLDNEW
« no previous file with comments | « mash/webtest/webtest.cc ('k') | media/mojo/services/mojo_media_application.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698