Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Side by Side Diff: content/common/mojo/mojo_shell_connection_impl.cc

Issue 2182643003: Remove shell::Connection* parameter to InterfaceFactory<T>::Create() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « components/leveldb/leveldb_app.cc ('k') | content/public/test/test_mojo_app.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/common/mojo/mojo_shell_connection_impl.h" 5 #include "content/common/mojo/mojo_shell_connection_impl.h"
6 6
7 #include <queue> 7 #include <queue>
8 #include <utility> 8 #include <utility>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 189 matching lines...) Expand 10 before | Expand all | Expand 10 after
200 } 200 }
201 201
202 bool OnStop() override { 202 bool OnStop() override {
203 callback_task_runner_->PostTask(FROM_HERE, stop_callback_); 203 callback_task_runner_->PostTask(FROM_HERE, stop_callback_);
204 return true; 204 return true;
205 } 205 }
206 206
207 ///////////////////////////////////////////////////////////////////////////// 207 /////////////////////////////////////////////////////////////////////////////
208 // shell::InterfaceFactory<shell::mojom::ServiceFactory> implementation 208 // shell::InterfaceFactory<shell::mojom::ServiceFactory> implementation
209 209
210 void Create(shell::Connection* connection, 210 void Create(const shell::Identity& remote_identity,
211 shell::mojom::ServiceFactoryRequest request) override { 211 shell::mojom::ServiceFactoryRequest request) override {
212 DCHECK(io_thread_checker_.CalledOnValidThread()); 212 DCHECK(io_thread_checker_.CalledOnValidThread());
213 factory_bindings_.AddBinding(this, std::move(request)); 213 factory_bindings_.AddBinding(this, std::move(request));
214 } 214 }
215 215
216 ///////////////////////////////////////////////////////////////////////////// 216 /////////////////////////////////////////////////////////////////////////////
217 // shell::mojom::ServiceFactory implementation 217 // shell::mojom::ServiceFactory implementation
218 218
219 void CreateService(shell::mojom::ServiceRequest request, 219 void CreateService(shell::mojom::ServiceRequest request,
220 const mojo::String& name) override { 220 const mojo::String& name) override {
(...skipping 220 matching lines...) Expand 10 before | Expand all | Expand 10 after
441 } 441 }
442 442
443 void MojoShellConnectionImpl::GetInterface( 443 void MojoShellConnectionImpl::GetInterface(
444 shell::mojom::InterfaceProvider* provider, 444 shell::mojom::InterfaceProvider* provider,
445 const mojo::String& interface_name, 445 const mojo::String& interface_name,
446 mojo::ScopedMessagePipeHandle request_handle) { 446 mojo::ScopedMessagePipeHandle request_handle) {
447 provider->GetInterface(interface_name, std::move(request_handle)); 447 provider->GetInterface(interface_name, std::move(request_handle));
448 } 448 }
449 449
450 } // namespace content 450 } // namespace content
OLDNEW
« no previous file with comments | « components/leveldb/leveldb_app.cc ('k') | content/public/test/test_mojo_app.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698