Remove shell::Connection* parameter to InterfaceFactory<T>::Create()

services/shell/public/cpp/lib/interface_registry.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "services/shell/public/cpp/interface_registry.h"
 
 #include "services/shell/public/cpp/connection.h"
 
 namespace shell {
 
@@ skipping 46 matching lines @@
 // mojom::InterfaceProvider:
 void InterfaceRegistry::GetInterface(const mojo::String& interface_name,
                                      mojo::ScopedMessagePipeHandle handle) {
   if (is_paused_) {
     pending_interface_requests_.emplace(interface_name, std::move(handle));
     return;
   }
 
   auto iter = name_to_binder_.find(interface_name);
   if (iter != name_to_binder_.end()) {
-    iter->second->BindInterface(connection_, interface_name, std::move(handle));
+    iter->second->BindInterface(connection_->GetRemoteIdentity(),

[Ken Rockot(use gerrit already), 2016/07/26 00:14:46]

None of the uses with a null connection need the remote identity, so can we just
pass a dummy Identity if connection_ is null?

+                                interface_name,
+                                std::move(handle));
   } else if (connection_ && !connection_->AllowsInterface(interface_name)) {
     LOG(ERROR) << "Connection CapabilityFilter prevented binding to "
                << "interface: " << interface_name << " connection_name:"
                << connection_->GetConnectionName() << " remote_name:"
                << connection_->GetRemoteIdentity().name();
   } else if (!default_binder_.is_null()) {
     default_binder_.Run(interface_name, std::move(handle));
+  } else {
+    LOG(ERROR) << "Failed to locate a binder for interface: " << interface_name;
   }
 }
 
 bool InterfaceRegistry::SetInterfaceBinderForName(
     std::unique_ptr<InterfaceBinder> binder,
     const std::string& interface_name) {
   if (!connection_ ||
       (connection_ && connection_->AllowsInterface(interface_name))) {
     RemoveInterface(interface_name);
     name_to_binder_[interface_name] = std::move(binder);
     return true;
   }
   return false;
 }
 
 }  // namespace shell