Update RequestTrigger to GestureType in permission report

Update RequestTrigger to GestureType in permission report

Updated to match the corresponding proto in server side to allow a non boolean value. Changes also made in the permission reporter that a PermissionRequestGestureType enum value will be passed instead of boolean.

BUG=613883
Committed: https://crrev.com/f4f51e6797a9794649c5b30104502f75f192b215
Cr-Commit-Position: refs/heads/master@{#408039}

[stefanocs, 2016-07-26 03:57:37]

Description was changed from

==========
Update RequestTrigger to GestureType in permission report

BUG=613883
==========

to

==========
Update RequestTrigger to GestureType in permission report

Updated to match the corresponding proto in server side. Changes also made in
the permission reporter that a PermissionRequestGestureType enum value will be
passed instead of boolean.

BUG=613883
==========

[stefanocs, 2016-07-26 03:58:23]

Description was changed from

==========
Update RequestTrigger to GestureType in permission report

Updated to match the corresponding proto in server side. Changes also made in
the permission reporter that a PermissionRequestGestureType enum value will be
passed instead of boolean.

BUG=613883
==========

to

==========
Update RequestTrigger to GestureType in permission report

Updated to match the corresponding proto in server side to allow a non boolean
value. Changes also made in the permission reporter that a
PermissionRequestGestureType enum value will be passed instead of boolean.

BUG=613883
==========

[stefanocs, 2016-07-26 04:58:50]

stefanocs@google.com changed reviewers:
+ kcarattini@chromium.org, raymes@chromium.org

[kcarattini, 2016-07-26 06:03:27]

https://codereview.chromium.org/2178213003/diff/20001/chrome/browser/permissi...
File chrome/browser/permissions/permission_uma_util.cc (right):

https://codereview.chromium.org/2178213003/diff/20001/chrome/browser/permissi...
chrome/browser/permissions/permission_uma_util.cc:393:
PermissionRequestGestureType::UNKNOWN);
Why not "unspecified" like the report type?

https://codereview.chromium.org/2178213003/diff/20001/chrome/browser/safe_bro...
File chrome/browser/safe_browsing/ui_manager.h (right):

https://codereview.chromium.org/2178213003/diff/20001/chrome/browser/safe_bro...
chrome/browser/safe_browsing/ui_manager.h:38: enum class
PermissionRequestGestureType;
Where is this defined?

[stefanocs, 2016-07-26 06:08:31]

https://codereview.chromium.org/2178213003/diff/20001/chrome/browser/permissi...
File chrome/browser/permissions/permission_uma_util.cc (right):

https://codereview.chromium.org/2178213003/diff/20001/chrome/browser/permissi...
chrome/browser/permissions/permission_uma_util.cc:393:
PermissionRequestGestureType::UNKNOWN);
On 2016/07/26 06:03:26, kcarattini wrote:
> Why not "unspecified" like the report type?

I'm reusing an existing enum. I think it has a similar meaning.

https://codereview.chromium.org/2178213003/diff/20001/chrome/browser/safe_bro...
File chrome/browser/safe_browsing/ui_manager.h (right):

https://codereview.chromium.org/2178213003/diff/20001/chrome/browser/safe_bro...
chrome/browser/safe_browsing/ui_manager.h:38: enum class
PermissionRequestGestureType;
On 2016/07/26 06:03:26, kcarattini wrote:
> Where is this defined?

It should be in chrome/browser/permissions/permission_request.h
(probably not updated yet in codesearch
https://codereview.chromium.org/2124703002)

[kcarattini, 2016-07-26 06:38:39]

lgtm

[raymes, 2016-07-27 01:42:06]

lgtm

https://codereview.chromium.org/2178213003/diff/20001/chrome/browser/safe_bro...
File chrome/browser/safe_browsing/permission_reporter.h (right):

https://codereview.chromium.org/2178213003/diff/20001/chrome/browser/safe_bro...
chrome/browser/safe_browsing/permission_reporter.h:25: enum class
PermissionRequestGestureType;
AFAIK if you pass an argument by value then you can't forward declare the
parameter, you must include it.

https://codereview.chromium.org/2178213003/diff/20001/chrome/browser/safe_bro...
File chrome/browser/safe_browsing/ping_manager.cc (right):

https://codereview.chromium.org/2178213003/diff/20001/chrome/browser/safe_bro...
chrome/browser/safe_browsing/ping_manager.cc:143: PermissionRequestGestureType
gesture_type) {
nit: must include permission_request.h

https://codereview.chromium.org/2178213003/diff/20001/chrome/browser/safe_bro...
File chrome/browser/safe_browsing/ping_manager.h (right):

https://codereview.chromium.org/2178213003/diff/20001/chrome/browser/safe_bro...
chrome/browser/safe_browsing/ping_manager.h:34: enum class
PermissionRequestGestureType;
same here

https://codereview.chromium.org/2178213003/diff/20001/chrome/browser/safe_bro...
File chrome/browser/safe_browsing/ui_manager.cc (right):

https://codereview.chromium.org/2178213003/diff/20001/chrome/browser/safe_bro...
chrome/browser/safe_browsing/ui_manager.cc:288: PermissionRequestGestureType
gesture_type) {
nit: must include permission_request.h

https://codereview.chromium.org/2178213003/diff/20001/chrome/browser/safe_bro...
File chrome/browser/safe_browsing/ui_manager.h (right):

https://codereview.chromium.org/2178213003/diff/20001/chrome/browser/safe_bro...
chrome/browser/safe_browsing/ui_manager.h:38: enum class
PermissionRequestGestureType;
same here

[stefanocs, 2016-07-27 02:58:19]

Thanks!

https://codereview.chromium.org/2178213003/diff/20001/chrome/browser/safe_bro...
File chrome/browser/safe_browsing/permission_reporter.h (right):

https://codereview.chromium.org/2178213003/diff/20001/chrome/browser/safe_bro...
chrome/browser/safe_browsing/permission_reporter.h:25: enum class
PermissionRequestGestureType;
On 2016/07/27 01:42:05, raymes wrote:
> AFAIK if you pass an argument by value then you can't forward declare the
> parameter, you must include it.

Done.

https://codereview.chromium.org/2178213003/diff/20001/chrome/browser/safe_bro...
File chrome/browser/safe_browsing/ping_manager.cc (right):

https://codereview.chromium.org/2178213003/diff/20001/chrome/browser/safe_bro...
chrome/browser/safe_browsing/ping_manager.cc:143: PermissionRequestGestureType
gesture_type) {
On 2016/07/27 01:42:05, raymes wrote:
> nit: must include permission_request.h

Done. Included in header.

https://codereview.chromium.org/2178213003/diff/20001/chrome/browser/safe_bro...
File chrome/browser/safe_browsing/ping_manager.h (right):

https://codereview.chromium.org/2178213003/diff/20001/chrome/browser/safe_bro...
chrome/browser/safe_browsing/ping_manager.h:34: enum class
PermissionRequestGestureType;
On 2016/07/27 01:42:05, raymes wrote:
> same here

Done.

https://codereview.chromium.org/2178213003/diff/20001/chrome/browser/safe_bro...
File chrome/browser/safe_browsing/ui_manager.cc (right):

https://codereview.chromium.org/2178213003/diff/20001/chrome/browser/safe_bro...
chrome/browser/safe_browsing/ui_manager.cc:288: PermissionRequestGestureType
gesture_type) {
On 2016/07/27 01:42:05, raymes wrote:
> nit: must include permission_request.h

Done. Included in the header.

https://codereview.chromium.org/2178213003/diff/20001/chrome/browser/safe_bro...
File chrome/browser/safe_browsing/ui_manager.h (right):

https://codereview.chromium.org/2178213003/diff/20001/chrome/browser/safe_bro...
chrome/browser/safe_browsing/ui_manager.h:38: enum class
PermissionRequestGestureType;
On 2016/07/27 01:42:05, raymes wrote:
> same here

Done.

[stefanocs, 2016-07-27 02:59:50]

stefanocs@google.com changed reviewers:
+ jialiul@chromium.org, vakh@chromium.org

[stefanocs, 2016-07-27 02:59:50]

jialiul@chromium.org and vakh@chromium.org: Please review changes in
chrome/browser/safe_browsing/

[Jialiu Lin, 2016-07-27 03:32:34]

lgtm

[stefanocs, 2016-07-27 03:35:41]

The CQ bit was checked by stefanocs@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-27 03:35:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-27 04:18:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-27 04:18:24]

Dry run: This issue passed the CQ dry run.

[stefanocs, 2016-07-27 04:21:17]

The CQ bit was checked by stefanocs@google.com

[stefanocs, 2016-07-27 04:21:17]

The patchset sent to the CQ was uploaded after l-g-t-m from
kcarattini@chromium.org, raymes@chromium.org
Link to the patchset: https://codereview.chromium.org/2178213003/#ps40001
(title: "Resolve nits")

[commit-bot: I haz the power, 2016-07-27 04:21:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-27 04:24:43]

Description was changed from

==========
Update RequestTrigger to GestureType in permission report

Updated to match the corresponding proto in server side to allow a non boolean
value. Changes also made in the permission reporter that a
PermissionRequestGestureType enum value will be passed instead of boolean.

BUG=613883
==========

to

==========
Update RequestTrigger to GestureType in permission report

Updated to match the corresponding proto in server side to allow a non boolean
value. Changes also made in the permission reporter that a
PermissionRequestGestureType enum value will be passed instead of boolean.

BUG=613883
==========

[commit-bot: I haz the power, 2016-07-27 04:24:45]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-07-27 04:26:08]

Description was changed from

==========
Update RequestTrigger to GestureType in permission report

Updated to match the corresponding proto in server side to allow a non boolean
value. Changes also made in the permission reporter that a
PermissionRequestGestureType enum value will be passed instead of boolean.

BUG=613883
==========

to

==========
Update RequestTrigger to GestureType in permission report

Updated to match the corresponding proto in server side to allow a non boolean
value. Changes also made in the permission reporter that a
PermissionRequestGestureType enum value will be passed instead of boolean.

BUG=613883

Committed: https://crrev.com/f4f51e6797a9794649c5b30104502f75f192b215
Cr-Commit-Position: refs/heads/master@{#408039}
==========

[commit-bot: I haz the power, 2016-07-27 04:26:09]

Patchset 3 (id:??) landed as
https://crrev.com/f4f51e6797a9794649c5b30104502f75f192b215
Cr-Commit-Position: refs/heads/master@{#408039}